Skip to content

Commit 7875e18

Browse files
committed
Fix OpenRTBReading.json4sNative and OpenRTBReading.json4sNative benchmarks for Scala 3
1 parent 6c4c6c6 commit 7875e18

File tree

3 files changed

+8
-12
lines changed

3 files changed

+8
-12
lines changed

build.sbt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,7 @@ lazy val `jsoniter-scala-benchmark` = crossProject(JVMPlatform, JSPlatform)
266266
"com.dslplatform" %% "dsl-json-scala" % "2.0.2"
267267
)
268268
case _ => Seq(
269+
"org.scala-lang" %% "scala3-staging" % scalaVersion.value, // required by `OpenRTBReading.json4sNative` and `OpenRTBReading.json4sNative` benchmarks for Scala 3
269270
"io.bullet" %%% "borer-derivation" % "1.16.1"
270271
)
271272
}),

jsoniter-scala-benchmark/jvm/src/test/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/OpenRTBReadingSpec.scala

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,8 @@ class OpenRTBReadingSpec extends BenchmarkSpecBase {
1313
benchmark.circe() shouldBe benchmark.obj
1414
benchmark.circeJsoniter() shouldBe benchmark.obj
1515
benchmark.jacksonScala() shouldBe benchmark.obj
16-
// FIXME: json4s.jackson throws org.json4s.MappingException: Can't find ScalaSig for class com.github.plokhotnyuk.jsoniter_scala.benchmark.OpenRTB$BidRequest
17-
// benchmark.json4sJackson() shouldBe benchmark.obj
18-
// FIXME: json4s.native throws org.json4s.MappingException: Can't find ScalaSig for class com.github.plokhotnyuk.jsoniter_scala.benchmark.OpenRTB$BidRequest
19-
// benchmark.json4sNative() shouldBe benchmark.obj
16+
benchmark.json4sJackson() shouldBe benchmark.obj
17+
benchmark.json4sNative() shouldBe benchmark.obj
2018
benchmark.jsoniterScala() shouldBe benchmark.obj
2119
benchmark.playJson() shouldBe benchmark.obj
2220
benchmark.playJsonJsoniter() shouldBe benchmark.obj
@@ -34,10 +32,8 @@ class OpenRTBReadingSpec extends BenchmarkSpecBase {
3432
intercept[Throwable](b.circe())
3533
intercept[Throwable](b.circeJsoniter())
3634
intercept[Throwable](b.jacksonScala())
37-
// FIXME: json4s.jackson throws org.json4s.MappingException: Can't find ScalaSig for class com.github.plokhotnyuk.jsoniter_scala.benchmark.OpenRTB$BidRequest
38-
// intercept[Throwable](b.json4sJackson())
39-
// FIXME: json4s.native throws org.json4s.MappingException: Can't find ScalaSig for class com.github.plokhotnyuk.jsoniter_scala.benchmark.OpenRTB$BidRequest
40-
// intercept[Throwable](b.json4sNative())
35+
intercept[Throwable](b.json4sJackson())
36+
intercept[Throwable](b.json4sNative())
4137
intercept[Throwable](b.jsoniterScala())
4238
intercept[Throwable](b.playJson())
4339
intercept[Throwable](b.playJsonJsoniter())

jsoniter-scala-benchmark/shared/src/main/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/OpenRTBReading.scala

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class OpenRTBReading extends OpenRTBBenchmark {
3535

3636
jacksonMapper.readValue[BidRequest](jsonBytes)
3737
}
38-
/* FIXME: json4s.jackson throws org.json4s.MappingException: Can't find ScalaSig for class com.github.plokhotnyuk.jsoniter_scala.benchmark.OpenRTB$BidRequest
38+
3939
@Benchmark
4040
@annotation.nowarn
4141
def json4sJackson(): BidRequest = {
@@ -45,8 +45,7 @@ class OpenRTBReading extends OpenRTBBenchmark {
4545

4646
mapper.readValue[JValue](jsonBytes, jValueType).extract[BidRequest]
4747
}
48-
*/
49-
/* FIXME: json4s.native throws org.json4s.MappingException: Can't find ScalaSig for class com.github.plokhotnyuk.jsoniter_scala.benchmark.OpenRTB$BidRequest
48+
5049
@Benchmark
5150
@annotation.nowarn
5251
def json4sNative(): BidRequest = {
@@ -57,7 +56,7 @@ class OpenRTBReading extends OpenRTBBenchmark {
5756

5857
parse(new String(jsonBytes, UTF_8)).extract[BidRequest]
5958
}
60-
*/
59+
6160
@Benchmark
6261
def jsoniterScala(): BidRequest = {
6362
import com.github.plokhotnyuk.jsoniter_scala.benchmark.JsoniterScalaCodecs._

0 commit comments

Comments
 (0)