Skip to content

Commit c6862cd

Browse files
committed
Clean up of benchmarks
1 parent af323d6 commit c6862cd

File tree

2 files changed

+7
-16
lines changed

2 files changed

+7
-16
lines changed

jsoniter-scala-benchmark/shared/src/main/scala/com/github/plokhotnyuk/jsoniter_scala/benchmark/JacksonSerDesers.scala

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -110,15 +110,10 @@ class SuiteEnumSerializer extends JsonSerializer[SuitEnum] {
110110
}
111111

112112
class SuiteEnumDeserializer extends JsonDeserializer[SuitEnum] {
113-
override def deserialize(jp: JsonParser, ctxt: DeserializationContext): SuitEnum = {
114-
val s = jp.getValueAsString
115-
var x: SuitEnum = null
116-
try x = SuitEnum.withName(s) catch {
117-
case _: NoSuchElementException =>
113+
override def deserialize(jp: JsonParser, ctxt: DeserializationContext): SuitEnum =
114+
try SuitEnum.withName(jp.getValueAsString) catch {
115+
case _: NoSuchElementException => ctxt.handleUnexpectedToken(classOf[SuitEnum], jp).asInstanceOf[SuitEnum]
118116
}
119-
if (x eq null) ctxt.handleUnexpectedToken(classOf[SuitEnum], jp)
120-
x
121-
}
122117
}
123118

124119
class SuitADTSerializer extends JsonSerializer[SuitADT] {

jsoniter-scala-benchmark/shared/src/main/scala/com/github/plokhotnyuk/jsoniter_scala/benchmark/SprayFormats.scala

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -222,18 +222,14 @@ object SprayFormats extends DefaultJsonProtocol {
222222
s => suite.getOrElse(s, throw new IllegalArgumentException("SuitADT"))
223223
}
224224
implicit val suitEnumJsonFormat: RootJsonFormat[SuitEnum.SuitEnum] = new RootJsonFormat[SuitEnum.SuitEnum] {
225-
override def read(json: JsValue): SuitEnum.SuitEnum = {
226-
var x: SuitEnum.SuitEnum = null
225+
override def read(json: JsValue): SuitEnum.SuitEnum =
227226
json match {
228227
case js: JsString =>
229-
try x = SuitEnum.withName(js.value) catch {
230-
case _: NoSuchElementException =>
228+
try SuitEnum.withName(js.value) catch {
229+
case _: NoSuchElementException => deserializationError("Expected JSON string of value from SuitEnum")
231230
}
232-
case _ =>
231+
case _ => deserializationError("Expected JSON string of value from SuitEnum")
233232
}
234-
if (x eq null) deserializationError(s"Expected JSON string of value from SuitEnum")
235-
x
236-
}
237233

238234
override def write(ev: SuitEnum.SuitEnum): JsValue = new JsString(ev.toString)
239235
}

0 commit comments

Comments
 (0)