Skip to content

Commit 86c1fca

Browse files
committed
- Align overview with sections of PLIP submittal process
- Add designated packages, teams, repos with a default
1 parent c8edc3c commit 86c1fca

File tree

1 file changed

+33
-15
lines changed

1 file changed

+33
-15
lines changed

docs/contributing/core/plips.md

Lines changed: 33 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,35 @@ The Plone Framework Team reviews all PLIPs to make sure that it's in the best in
1616

1717
## Process overview
1818

19-
1. Developer submits a PLIP.
20-
2. [SOME_INDETERMINATE_TEAM] approves the PLIP for inclusion into Plone core for a given release.
21-
3. Developer implements the PLIP, including code, tests, and documentation.
22-
4. Developer creates a pull request of the PLIP for review by the [SOME_INDETERMINATE_TEAM].
23-
5. [SOME_INDETERMINATE_TEAM] reviews the PLIP and gives feedback.
24-
6. Developer addresses concerns from the feedback, and resubmits the PLIP, if necessary.
25-
7. Repeat the two previous steps, until both the [SOME_INDETERMINATE_TEAM] and developer are happy with the result.
26-
8. [SOMEBODY] approves the PLIP for merge.
27-
9. [SOMEBODY] merges the PLIP.
19+
1. Developer submits a PLIP and solicits feedback.
20+
2. Developer addresses concerns from the feedback, and resubmits the PLIP, if necessary.
21+
3. The designated team approves the PLIP for inclusion into Plone core for a given release.
22+
4. Developer implements the PLIP, including code, tests, and documentation.
23+
5. Developer creates a pull request of the PLIP for review by the designated team.
24+
6. The designated team reviews the pull request of the PLIP and gives feedback.
25+
7. Repeat the two previous steps, until both the designated team and developer are happy with the result.
26+
8. A designated team member approves the PLIP for merge.
27+
9. A designated team member merges the PLIP.
2828

2929
In rare circumstances, a PLIP may be rejected.
3030
This is usually the result of the developer not responding to feedback or dropping out of the process.
3131

3232

33-
(submit-a-plip)=
33+
(designated-teams-label)=
34+
35+
## Designated teams
36+
37+
The following packages and repositories have designated teams that you can contact by `@`-ing them in its GitHub issue tracker.
38+
If the repository is not listed, use the default repository for `Products.CMFPlone`.
39+
40+
| Package | Repository | Team |
41+
|---|---|---|
42+
| `Products.CMFPlone` | https://github.com/plone/Products.CMFPlone | not applicable |
43+
| Classic UI | https://github.com/plone/plone.classicui | `@plone/ClassicUI-Team` |
44+
| Volto | https://github.com/plone/volto | `@plone/volto-team` |
45+
46+
47+
(submit-a-plip-label)=
3448

3549
## Submit a PLIP
3650

@@ -61,16 +75,22 @@ Now that you are prepared, submit your PLIP.
6175

6276
4. When done, click {guilabel}`Submit new issue` to submit your PLIP.
6377

64-
5. If it does not automatically assign the label {guilabel}`03 type: feature (plip)`, then assign that label to the issue to make it easier to find.
78+
5. If GitHub does not automatically assign the label {guilabel}`03 type: feature (plip)`, then assign that label to the issue to make it easier to find.
6579

6680

6781
## Get feedback
6882

69-
After you submit your PLIP, solicit feedback for your idea on the [Plone Community Forum](https://community.plone.org/).
83+
After you submit your PLIP, solicit feedback for your idea on the [Plone Community Forum](https://community.plone.org/) and through the repository's issue tracker.
7084

7185
You may revise your PLIP based on feedback.
7286

73-
If you need help at any point in this process, please contact a member of the [SOME_INDETERMINATE_TEAM] personally or ask for help at the [Framework Team Space](https://community.plone.org/c/development/framework-team/12).
87+
If you need help at any point in this process, you can either `@` the team or personally contact a member of the designated team.
88+
89+
90+
## Team approves proposal
91+
92+
After incorporating feedback to your proposal, you can request a final review and approval for inclusion in Plone.
93+
Every PLIP must be approved by the designated team.
7494

7595

7696
## Implement your PLIP
@@ -260,5 +280,3 @@ In general, PLIPs shouldn't take more than a year, otherwise they should be clos
260280

261281
If a PLIP isn't accepted in core, it doesn't mean it's a bad idea.
262282
It is often the case that there are competing implementations, and the community wants to see it vetted as an add-on before "blessing" a particular implementation.
263-
264-

0 commit comments

Comments
 (0)