add Aqua.jl for general QA testing

Author: sjkelly

Project.toml

@@ -24,6 +24,7 @@ UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
 YAML = "ddb6d928-2868-570f-bddf-ab3f9cf99eb6"
 
 [compat]
+Aqua = "0.6"
 CodecZlib = "0.6, 0.7"
 DashBase = "0.1"
 DashCoreComponents = "2.0.0"
@@ -40,7 +41,8 @@ YAML = "0.4.7"
 julia = "1.6"
 
 [extras]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["Test"]
+test = ["Aqua", "Test"]

test/aqua.jl

@@ -0,0 +1,6 @@
+using Aqua
+
+# ideally we get both these tests to work, but:
+# stale_deps is ignored to help transition from DashCoreComponents
+# amiguities is ignored because they originate outside the package
+Aqua.test_all(Dash; ambiguities=false, stale_deps=false)

test/runtests.jl

@@ -12,4 +12,5 @@ include("callbacks.jl")
 include("components_utils.jl")
 include("table_format.jl")
 include("reload_hash.jl")
+include("aqua.jl")
 #include("dev.jl")