remove type piracy

Author: BeastyBlacksmith

src/app/dashapp.jl

@@ -48,7 +48,13 @@ function Base.getindex(component::DashBase.Component, id::AbstractString)
   component.id == id && return component
   hasproperty(component, :children) || return nothing
   cc = component.children
-  cc isa Union{VecChildTypes, DashBase.Component, Vector{Any}} ? cc[id] : nothing
+  return if cc isa Union{VecChildTypes, DashBase.Component}
+        cc[id]
+    elseif cc isa AbstractVector
+        identity.(filter(x->hasproperty(x, :id), cc))[id]
+    else
+        nothing
+    end
 end
 function Base.getindex(children::VecChildTypes, id::AbstractString)
   for element in children
@@ -57,14 +63,6 @@ function Base.getindex(children::VecChildTypes, id::AbstractString)
     el !== nothing && return el
   end
 end
-function Base.getindex(children::AbstractVector, id::AbstractString)
-  for element in children
-    hasproperty(element, :id) || continue
-    element.id == id && return element
-    el = element[id]
-    el !== nothing && return el
-  end
-end
 
 #only name, index_string and layout are available to set
 function Base.setproperty!(app::DashApp, property::Symbol, value)

test/core.jl

@@ -213,4 +213,5 @@ end
             html_div(id = "my-div2")
         end
     @test app["target"].id == "target"
+    @test app["ups"] === nothing
 end