Skip to content

Commit da85fa9

Browse files
committed
remove FakeTriggered
1 parent d184e16 commit da85fa9

File tree

2 files changed

+3
-19
lines changed

2 files changed

+3
-19
lines changed

src/handler/callback_context.jl

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,6 @@ using .Contexts
22
const CallbackContextItems = Union{Nothing, Vector{NamedTuple}}
33
const TriggeredParam = NamedTuple{(:prop_id, :value)}
44

5-
struct FakeTriggeredParams <: AbstractVector{TriggeredParam}
6-
end
7-
Base.size(v::FakeTriggeredParams) = (1,)
8-
Base.isempty(v::FakeTriggeredParams) = true
9-
Base.IndexStyle(::Type{FakeTriggeredParams}) = IndexLinear()
10-
Base.length(v::FakeTriggeredParams) = 1
11-
function Base.getindex(v::FakeTriggeredParams, i::Int)
12-
i != 1 && throw(BoundsError(v, i))
13-
return (prop_id = ".", value = nothing)
14-
end
155

166
mutable struct CallbackContext
177
response::HTTP.Response
@@ -20,15 +10,11 @@ mutable struct CallbackContext
2010
outputs_list::Vector{Any}
2111
inputs_list::Vector{Any}
2212
states_list::Vector{Any}
23-
triggered::Union{Vector{TriggeredParam}, FakeTriggeredParams}
13+
triggered::Vector{TriggeredParam}
2414
function CallbackContext(response, outputs_list, inputs_list, states_list, changed_props)
2515
input_values = inputs_list_to_dict(inputs_list)
2616
state_values = inputs_list_to_dict(states_list)
27-
if !isempty(changed_props)
28-
triggered = TriggeredParam[(prop_id = id, value = input_values[id]) for id in changed_props]
29-
else
30-
triggered = FakeTriggeredParams()
31-
end
17+
triggered = TriggeredParam[(prop_id = id, value = input_values[id]) for id in changed_props]
3218
return new(response, input_values, state_values, outputs_list, inputs_list, states_list, triggered)
3319
end
3420
end

test/callbacks.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315,9 +315,7 @@ end
315315

316316
callback!(app, Output("test-out", "children"), Input("test-out", "value")) do value
317317
context = callback_context()
318-
@test length(context.triggered) == 1
319-
@test context.triggered[1].prop_id == "."
320-
@test isnothing(context.triggered[1].value)
318+
@test length(context.triggered) == 0
321319
@test isempty(context.triggered)
322320
return string(value)
323321
end

0 commit comments

Comments
 (0)