code cleanup

Author: KoolADE85

CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to `dash-ag-grid` will be documented in this file.
 This project adheres to [Semantic Versioning](https://semver.org/).
 Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source Dash AG Grid repo
 
+## UNRELEASED
+
+### Changed
+- Component is refactored to be a function component rather than a class
+
 ## [32.3.0rc0] - 2025-04-15
 
 ### Fixed

src/lib/fragments/AgGrid.react.js

@@ -290,7 +290,6 @@ export function DashAgGrid(props) {
     const selectionEventFired = useRef(false);
     const pauseSelections = useRef(false);
     const reference = useRef();
-    // const pendingChanges = useRef(null);
     const dataUpdates = useRef(false);
     const getDetailParams = useRef();
     const getRowsParams = useRef(null);
@@ -1290,7 +1289,7 @@ export function DashAgGrid(props) {
         }
     }, [props.selectedRows, gridApi]);
 
-    // 1. Handle gridApi initialization - basic setup
+    // Handle gridApi initialization - basic setup
     useEffect(() => {
         if (gridApi && gridApi !== prevGridApi) {
             updateColumnWidths(false);
@@ -1302,7 +1301,7 @@ export function DashAgGrid(props) {
         }
     }, [gridApi, prevGridApi, updateColumnWidths, onPaginationChanged]);
 
-    // 1a. Handle gridApi initialization - expanded groups tracking
+    // Handle gridApi initialization - expanded groups tracking
     useEffect(() => {
         if (gridApi && gridApi !== prevGridApi) {
             const groups = {};
@@ -1315,7 +1314,7 @@ export function DashAgGrid(props) {
         }
     }, [gridApi, prevGridApi, setOpenGroups]);
 
-    // 1b. Handle gridApi initialization - row transactions
+    // Handle gridApi initialization - row transactions
     useEffect(() => {
         if (gridApi && gridApi !== prevGridApi && rowTransactionState) {
             rowTransactionState.map((data) =>
@@ -1333,21 +1332,21 @@ export function DashAgGrid(props) {
         syncRowData,
     ]);
 
-    // 1c. Handle gridApi initialization - filter model application
+    // Handle gridApi initialization - filter model application
     useEffect(() => {
         if (gridApi && gridApi !== prevGridApi && !isEmpty(props.filterModel)) {
             gridApi.setFilterModel(props.filterModel);
         }
     }, [gridApi, prevGridApi, props.filterModel]);
 
-    // 1d. Handle gridApi initialization - column state application
+    // Handle gridApi initialization - column state application
     useEffect(() => {
         if (gridApi && gridApi !== prevGridApi && props.columnState) {
             setColumnState();
         }
     }, [gridApi, prevGridApi, props.columnState, setColumnState]);
 
-    // 1e. Handle gridApi initialization - action props with cleanup
+    // Handle gridApi initialization - action props with cleanup
     useEffect(() => {
         if (gridApi && gridApi !== prevGridApi) {
             const propsToSet = {};
@@ -1412,7 +1411,7 @@ export function DashAgGrid(props) {
         customSetProps,
     ]);
 
-    // 1f. Handle gridApi initialization - finalization
+    // Handle gridApi initialization - finalization
     useEffect(() => {
         if (gridApi && gridApi !== prevGridApi) {
             // Hydrate virtualRowData and finalize setup
@@ -1427,7 +1426,7 @@ export function DashAgGrid(props) {
         updateColumnState,
     ]);
 
-    // 2. Handle columnState push changes
+    // Handle columnState push changes
     useEffect(() => {
         if (
             gridApi &&
@@ -1442,7 +1441,7 @@ export function DashAgGrid(props) {
         }
     }, [props.columnState, props.loading_state, gridApi, columnState_push]);
 
-    // 3. Handle ID changes
+    // Handle ID changes
     useEffect(() => {
         if (props.id !== prevProps?.id) {
             if (props.id) {
@@ -1456,7 +1455,7 @@ export function DashAgGrid(props) {
         }
     }, [props.id]);
 
-    // 4. Handle infinite scrolling datasource
+    // Handle infinite scrolling datasource
     useEffect(() => {
         if (isDatasourceLoadedForInfiniteScrolling()) {
             const {rowData, rowCount} = props.getRowsResponse;
@@ -1465,7 +1464,7 @@ export function DashAgGrid(props) {
         }
     }, [props.getRowsResponse]);
 
-    // 5. Handle master detail response
+    // Handle master detail response
     useEffect(() => {
         if (
             props.masterDetail &&
@@ -1481,12 +1480,12 @@ export function DashAgGrid(props) {
         props.detailCellRendererParams,
     ]);
 
-    // 7. Handle dataUpdates reset
+    // Handle dataUpdates reset
     useEffect(() => {
         dataUpdates.current = false;
     });
 
-    // 8. Handle filter model updates
+    // Handle filter model updates
     useEffect(() => {
         if (
             gridApi &&
@@ -1498,7 +1497,7 @@ export function DashAgGrid(props) {
         }
     }, [props.filterModel, gridApi, prevGridApi]);
 
-    // 9. Handle pagination actions
+    // Handle pagination actions
     useEffect(() => {
         if (
             gridApi &&
@@ -1509,28 +1508,28 @@ export function DashAgGrid(props) {
         }
     }, [props.paginationGoTo, gridApi, prevGridApi, paginationGoTo]);
 
-    // 10. Handle scroll actions
+    // Handle scroll actions
     useEffect(() => {
         if (gridApi && gridApi === prevGridApi && props.scrollTo) {
             scrollTo();
         }
     }, [props.scrollTo, gridApi, prevGridApi, scrollTo]);
 
-    // 11. Handle column size updates
+    // Handle column size updates
     useEffect(() => {
         if (gridApi && gridApi === prevGridApi && props.columnSize) {
             updateColumnWidths();
         }
     }, [props.columnSize, gridApi, prevGridApi, updateColumnWidths]);
 
-    // 12. Handle column state reset
+    // Handle column state reset
     useEffect(() => {
         if (gridApi && gridApi === prevGridApi && props.resetColumnState) {
             resetColumnState();
         }
     }, [props.resetColumnState, gridApi, prevGridApi, resetColumnState]);
 
-    // 13. Handle CSV export
+    // Handle CSV export
     useEffect(() => {
         if (gridApi && gridApi === prevGridApi && props.exportDataAsCsv) {
             exportDataAsCsv(props.csvExportParams);
@@ -1543,7 +1542,7 @@ export function DashAgGrid(props) {
         exportDataAsCsv,
     ]);
 
-    // 14. Handle row selection actions
+    // Handle row selection actions
     useEffect(() => {
         if (gridApi && gridApi === prevGridApi) {
             if (props.selectAll) {
@@ -1567,14 +1566,14 @@ export function DashAgGrid(props) {
         deleteSelectedRows,
     ]);
 
-    // 15. Handle row transactions
+    // Handle row transactions
     useEffect(() => {
         if (gridApi && gridApi === prevGridApi && props.rowTransaction) {
             rowTransaction(props.rowTransaction);
         }
     }, [props.rowTransaction, gridApi, prevGridApi, rowTransaction]);
 
-    // 16. Handle column state updates
+    // Handle column state updates
     useEffect(() => {
         if (gridApi && gridApi === prevGridApi) {
             if (props.updateColumnState) {
@@ -1594,12 +1593,8 @@ export function DashAgGrid(props) {
         setColumnState,
     ]);
 
-    // End of hooks
-
     const {id, style, className, dashGridOptions, ...restProps} = props;
-
     const passingProps = pick(PASSTHRU_PROPS, restProps);
-
     const convertedProps = convertAllProps(
         omit(NO_CONVERT_PROPS, {...dashGridOptions, ...restProps})
     );

tests/test_cell_data_type_override.py

@@ -79,4 +79,4 @@ def test_cd001_cell_data_types_override(dash_duo):
         date_input_element = dash_duo.find_element(f'#{grid.id} .ag-date-field-input')
         date_input_element.send_keys("01172024" + Keys.ENTER)
 
-        # grid.wait_for_cell_text(0, 1, "17/01/2024")
+        grid.wait_for_cell_text(0, 1, "17/01/2024")