Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Commit 6167e15

Browse files
Merge branch 'dev' into 674-map-uirevision
2 parents ceff132 + 803b67b commit 6167e15

File tree

7 files changed

+24
-20
lines changed

7 files changed

+24
-20
lines changed

CHANGELOG.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,13 @@
22
All notable changes to this project will be documented in this file.
33
This project adheres to [Semantic Versioning](http://semver.org/).
44

5-
## [Unreleased]
5+
## [1.8.1] -2020-02-27
66
### Changed
7-
- [#743](https://github.com/plotly/dash-core-components/pull/743) Location component now emits an event on link update
7+
- [#762](https://github.com/plotly/dash-core-components/pull/762) Renamed async modules with hyphen `-` instead of tilde `~`
8+
9+
## [1.8.0] - 2020-02-04
10+
### Changed
11+
- [#743](https://github.com/plotly/dash-core-components/pull/743) Location component now emits an event on URL path update from Link component
812
- [#739](https://github.com/plotly/dash-core-components/pull/739) Async Slider and RangeSlider
913
- [#729](https://github.com/plotly/dash-core-components/pull/729) Handle case where dcc fails to load when used inside an iframe with a sandbox attribute that only has allow-scripts
1014

MANIFEST.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ include dash_core_components/dash_core_components.min.js
22
include dash_core_components/dash_core_components.min.js.map
33
include dash_core_components/dash_core_components-shared.js
44
include dash_core_components/dash_core_components-shared.js.map
5-
include dash_core_components/async~*.js
6-
include dash_core_components/async~*.js.map
5+
include dash_core_components/async-*.js
6+
include dash_core_components/async-*.js.map
77
include dash_core_components/metadata.json
88
include dash_core_components/package-info.json
99
include dash_core_components/plotly.min.js

dash_core_components_base/__init__.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,20 +52,20 @@
5252
_js_dist = []
5353

5454
_js_dist.extend([{
55-
'relative_package_path': 'async~{}.js'.format(async_resource),
55+
'relative_package_path': 'async-{}.js'.format(async_resource),
5656
'external_url': (
5757
'https://unpkg.com/dash-core-components@{}'
58-
'/dash_core_components/async~{}.js'
58+
'/dash_core_components/async-{}.js'
5959
).format(__version__, async_resource),
6060
'namespace': 'dash_core_components',
6161
'async': True
6262
} for async_resource in async_resources])
6363

6464
_js_dist.extend([{
65-
'relative_package_path': 'async~{}.js.map'.format(async_resource),
65+
'relative_package_path': 'async-{}.js.map'.format(async_resource),
6666
'external_url': (
6767
'https://unpkg.com/dash-core-components@{}'
68-
'/dash_core_components/async~{}.js.map'
68+
'/dash_core_components/async-{}.js.map'
6969
).format(__version__, async_resource),
7070
'namespace': 'dash_core_components',
7171
'dynamic': True
@@ -116,19 +116,19 @@
116116
'async': 'eager'
117117
},
118118
{
119-
'relative_package_path': 'async~plotlyjs.js',
119+
'relative_package_path': 'async-plotlyjs.js',
120120
'external_url': (
121121
'https://unpkg.com/dash-core-components@{}'
122-
'/dash_core_components/async~graph~plotlyjs.js'
122+
'/dash_core_components/async-plotlyjs.js'
123123
).format(__version__),
124124
'namespace': 'dash_core_components',
125125
'async': 'lazy'
126126
},
127127
{
128-
'relative_package_path': 'async~plotlyjs.js.map',
128+
'relative_package_path': 'async-plotlyjs.js.map',
129129
'external_url': (
130130
'https://unpkg.com/dash-core-components@{}'
131-
'/dash_core_components/async~graph~plotlyjs.js.map'
131+
'/dash_core_components/async-plotlyjs.js.map'
132132
).format(__version__),
133133
'namespace': 'dash_core_components',
134134
'dynamic': True

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "dash-core-components",
3-
"version": "1.7.1",
3+
"version": "1.8.1",
44
"description": "Core component suite for Dash",
55
"repository": {
66
"type": "git",

src/components/Graph.react.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,6 @@ const ControlledPlotlyGraph = memo(props => {
115115
);
116116
});
117117

118-
ControlledPlotlyGraph.propTypes = PropTypes.any;
119-
120118
PlotlyGraph.propTypes = {
121119
...privatePropTypes,
122120

@@ -515,6 +513,8 @@ PlotlyGraph.propTypes = {
515513
}),
516514
};
517515

516+
ControlledPlotlyGraph.propTypes = PlotlyGraph.propTypes;
517+
518518
PlotlyGraph.defaultProps = {
519519
...privateDefaultProps,
520520

tests/integration/graph/test_graph_varia.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def findSyncPlotlyJs(scripts):
2525

2626
def findAsyncPlotlyJs(scripts):
2727
for script in scripts:
28-
if "dash_core_components/async~plotlyjs" in script.get_attribute(
28+
if "dash_core_components/async-plotlyjs" in script.get_attribute(
2929
'src'
3030
):
3131
return script

webpack.config.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ module.exports = (env, argv) => {
5454
},
5555
externals,
5656
module: {
57-
noParse: /node_modules\/plotly.js/,
57+
noParse: /node_modules[\\\/]plotly.js/,
5858
rules: [
5959
{
6060
test: /\.jsx?$/,
@@ -65,7 +65,7 @@ module.exports = (env, argv) => {
6565
},
6666
{
6767
test: /\.jsx?$/,
68-
include: /node_modules\/(react-jsx-parser\/)/,
68+
include: /node_modules[\\\/](react-jsx-parser[\\\/])/,
6969
use: {
7070
loader: 'babel-loader',
7171
options: {
@@ -118,7 +118,7 @@ module.exports = (env, argv) => {
118118
chunks: 'async',
119119
minSize: 0,
120120
name(module, chunks, cacheGroupKey) {
121-
return `${cacheGroupKey}~${chunks[0].name}`;
121+
return `${cacheGroupKey}-${chunks[0].name}`;
122122
}
123123
},
124124
shared: {
@@ -134,7 +134,7 @@ module.exports = (env, argv) => {
134134
new WebpackDashDynamicImport(),
135135
new webpack.SourceMapDevToolPlugin({
136136
filename: '[file].map',
137-
exclude: ['async~plotlyjs']
137+
exclude: ['async-plotlyjs']
138138
})
139139
]
140140
}

0 commit comments

Comments
 (0)