fix searchable dropdown option removal. track search_value, instead of searchable

Author: TillerBurr

components/dash-core-components/src/fragments/Dropdown.react.js

@@ -39,7 +39,6 @@ const Dropdown = props => {
     const {
         id,
         clearable,
-        searchable,
         multi,
         options,
         setProps,
@@ -48,6 +47,7 @@ const Dropdown = props => {
         value,
     } = props;
     const [optionsCheck, setOptionsCheck] = useState(null);
+    const [searchValue, setSearchValue] = useState(null);
     const persistentOptions = useRef(null);
 
     if (!persistentOptions || !isEqual(options, persistentOptions.current)) {
@@ -115,14 +115,14 @@ const Dropdown = props => {
         [multi]
     );
 
-    const onInputChange = useCallback(
-        search_value => setProps({search_value}),
-        []
-    );
+    const onInputChange = useCallback(search_value => {
+        setProps({search_value});
+        setSearchValue(search_value);
+    }, []);
 
     useEffect(() => {
         if (
-            !searchable &&
+            !searchValue &&
             !isNil(sanitizedOptions) &&
             optionsCheck !== sanitizedOptions &&
             !isNil(value)

components/dash-core-components/tests/integration/dropdown/test_remove_option.py

@@ -1,5 +1,7 @@
 import json
 
+import pytest
+
 from dash import Dash, html, dcc, Output, Input
 from dash.exceptions import PreventUpdate
 
@@ -11,7 +13,8 @@
 ]
 
 
-def test_ddro001_remove_option_single(dash_dcc):
+@pytest.mark.parametrize("searchable", (True, False))
+def test_ddro001_remove_option_single(dash_dcc, searchable):
     dropdown_options = sample_dropdown_options
 
     app = Dash(__name__)
@@ -22,7 +25,7 @@ def test_ddro001_remove_option_single(dash_dcc):
             dcc.Dropdown(
                 options=dropdown_options,
                 value=value,
-                searchable=False,
+                searchable=searchable,
                 id="dropdown",
             ),
             html.Button("Remove option", id="remove"),
@@ -49,7 +52,8 @@ def on_change(val):
     dash_dcc.wait_for_text_to_equal("#value-output", "None")
 
 
-def test_ddro002_remove_option_multi(dash_dcc):
+@pytest.mark.parametrize("searchable", (True, False))
+def test_ddro002_remove_option_multi(dash_dcc, searchable):
     dropdown_options = sample_dropdown_options
 
     app = Dash(__name__)
@@ -62,7 +66,7 @@ def test_ddro002_remove_option_multi(dash_dcc):
                 value=value,
                 multi=True,
                 id="dropdown",
-                searchable=False,
+                searchable=searchable,
             ),
             html.Button("Remove option", id="remove"),
             html.Div(id="value-output"),