Skip to content

Commit 02a157a

Browse files
committed
Fix case of JavaScript and Python.
1 parent 157f871 commit 02a157a

File tree

10 files changed

+21
-21
lines changed

10 files changed

+21
-21
lines changed

CHANGELOG.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ clientside JavaScript callbacks via inline strings.
296296
## [0.39.0] - 2019-03-04
297297
### Added
298298
- [#436](https://github.com/plotly/dash/pull/436) Allow multiple outputs from a single callback.
299-
- [#367](https://github.com/plotly/dash/pull/367) Support custom javascript hooks to modify callback payloads and responses.
299+
- [#367](https://github.com/plotly/dash/pull/367) Support custom JavaScript hooks to modify callback payloads and responses.
300300
- [#623](https://github.com/plotly/dash/pull/623) Modify the flask response with custom cookies or headers, using `dash.callback_context.response`.
301301
- [renderer#93](https://github.com/plotly/dash-renderer/pull/93) Loading states API
302302

@@ -333,7 +333,7 @@ clientside JavaScript callbacks via inline strings.
333333
- Bump dash-core-components version from 0.43.0 to [0.43.1](https://github.com/plotly/dash-core-components/blob/master/CHANGELOG.md#0431---2019-02-11)
334334

335335
### Fixed
336-
- [#563](https://github.com/plotly/dash/pull/563) Fix collections.abc deprecation warning for python 3.8
336+
- [#563](https://github.com/plotly/dash/pull/563) Fix collections.abc deprecation warning for Python 3.8
337337

338338
## [0.36.0] - 2019-01-25
339339
### Removed
@@ -512,7 +512,7 @@ clientside JavaScript callbacks via inline strings.
512512
## 0.24.1 - 2018-08-10
513513
### Fixed
514514
- Fix bug [#321](https://github.com/plotly/dash/issues/321) where importing Dash components with no props would result in an error.
515-
- Fix a bug in 0.23.1 where importing components with arguments that are python keywords could cause an error. In particular, this fixes `dash-html-components` with Python 3.7.
515+
- Fix a bug in 0.23.1 where importing components with arguments that are Python keywords could cause an error. In particular, this fixes `dash-html-components` with Python 3.7.
516516

517517
## 0.24.0 - 2018-08-10
518518
### Added

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ As of Dash 1.2, the renderer bundle and its peer dependencies can be packed and
4545
5. `renderer build` runs 1, 2, 3, 4 in sequence as a complete build process from scratch.
4646
6. `renderer build local` runs the same order as in 5 and also generates source maps for debugging purposes. You also need to install dash-renderer with editable mode: `pip install -e .`.
4747

48-
When a change in renderer code doesn't reflect in your browser as expected, this could be: confused bundle generation, caching issue in a browser, python package not in `editable` mode, etc. The new tool reduces the risk of bundle assets by adding the digest to help compare asset changes.
48+
When a change in renderer code doesn't reflect in your browser as expected, this could be: confused bundle generation, caching issue in a browser, Python package not in `editable` mode, etc. The new tool reduces the risk of bundle assets by adding the digest to help compare asset changes.
4949

5050
## Python 2 And 3 Compatibility
5151

dash/dash.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1339,7 +1339,7 @@ def enable_dev_tools(
13391339
_reload.hash = generate_hash()
13401340

13411341
# find_loader should return None on __main__ but doesn't
1342-
# on some python versions https://bugs.python.org/issue14710
1342+
# on some Python versions https://bugs.python.org/issue14710
13431343
packages = [
13441344
pkgutil.find_loader(x)
13451345
for x in list(ComponentRegistry.registry) + ["dash_renderer"]

dash/development/_all_keywords.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# keyword.kwlist for both python 2 and 3
1+
# keyword.kwlist for both Python 2 and 3
22
python_keywords = {
33
"False",
44
"None",

dash/development/_py_components_generation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def __init__(self, {default_argtext}):
111111

112112

113113
def generate_class_file(typename, props, description, namespace):
114-
"""Generate a python class file (.py) given a class string.
114+
"""Generate a Python class file (.py) given a class string.
115115
116116
Parameters
117117
----------
@@ -169,7 +169,7 @@ def generate_classes_files(project_shortname, metadata, *component_generators):
169169

170170

171171
def generate_class(typename, props, description, namespace):
172-
"""Generate a python class object given a class string.
172+
"""Generate a Python class object given a class string.
173173
174174
Parameters
175175
----------

dash/development/_r_components_generation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@
119119
demo/.*\.html
120120
demo/.*\.css
121121
122-
# ignore python files/folders
122+
# ignore Python files/folders
123123
setup.py
124124
usage.py
125125
setup.py

dash/development/component_generator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ def cli():
140140
prog="dash-generate-components",
141141
formatter_class=_CombinedFormatter,
142142
description="Generate dash components by extracting the metadata "
143-
"using react-docgen. Then map the metadata to python classes.",
143+
"using react-docgen. Then map the metadata to Python classes.",
144144
)
145145
parser.add_argument("components_source", help="React components source directory.")
146146
parser.add_argument(

dash/development/component_loader.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,12 @@ def load_components(metadata_path, namespace="default_namespace"):
6262

6363
def generate_classes(namespace, metadata_path="lib/metadata.json"):
6464
"""Load React component metadata into a format Dash can parse, then create
65-
python class files.
65+
Python class files.
6666
6767
Usage: generate_classes()
6868
6969
Keyword arguments:
70-
namespace -- name of the generated python package (also output dir)
70+
namespace -- name of the generated Python package (also output dir)
7171
7272
metadata_path -- a path to a JSON file created by
7373
[`react-docgen`](https://github.com/reactjs/react-docgen).

dash/testing/browser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ def visit_and_snapshot(
127127

128128
def percy_snapshot(self, name="", wait_for_callbacks=False):
129129
"""percy_snapshot - visual test api shortcut to `percy_runner.snapshot`.
130-
It also combines the snapshot `name` with the python version.
130+
It also combines the snapshot `name` with the Python version.
131131
"""
132132
snapshot_name = "{} - py{}.{}".format(
133133
name, sys.version_info.major, sys.version_info.minor

tests/integration/devtools/test_devtools_error_handling.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,23 +47,23 @@ def test_dveh001_python_errors(dash_duo):
4747
dev_tools_hot_reload=False,
4848
)
4949

50-
dash_duo.percy_snapshot("devtools - python exception - start")
50+
dash_duo.percy_snapshot("devtools - Python exception - start")
5151

5252
dash_duo.find_element("#python").click()
5353
dash_duo.wait_for_text_to_equal(dash_duo.devtools_error_count_locator, "1")
54-
dash_duo.percy_snapshot("devtools - python exception - closed")
54+
dash_duo.percy_snapshot("devtools - Python exception - closed")
5555

5656
dash_duo.find_element(".test-devtools-error-toggle").click()
57-
dash_duo.percy_snapshot("devtools - python exception - open")
57+
dash_duo.percy_snapshot("devtools - Python exception - open")
5858

5959
dash_duo.find_element(".test-devtools-error-toggle").click()
6060
dash_duo.find_element("#python").click()
6161

6262
dash_duo.wait_for_text_to_equal(dash_duo.devtools_error_count_locator, "2")
63-
dash_duo.percy_snapshot("devtools - python exception - 2 errors")
63+
dash_duo.percy_snapshot("devtools - Python exception - 2 errors")
6464

6565
dash_duo.find_element(".test-devtools-error-toggle").click()
66-
dash_duo.percy_snapshot("devtools - python exception - 2 errors open")
66+
dash_duo.percy_snapshot("devtools - Python exception - 2 errors open")
6767

6868
# the top (first) error is the most recent one - ie from the second click
6969
error0 = get_error_html(dash_duo, 0)
@@ -135,7 +135,7 @@ def update_output(n_clicks):
135135
if n_clicks == 1:
136136
raise PreventUpdate
137137
if n_clicks == 2:
138-
raise Exception("An actual python exception")
138+
raise Exception("An actual Python exception")
139139

140140
return "button clicks: {}".format(n_clicks)
141141

@@ -263,7 +263,7 @@ def update_outputs(n_clicks):
263263

264264
dash_duo.find_element("#multi-output").click()
265265
dash_duo.wait_for_text_to_equal(dash_duo.devtools_error_count_locator, "1")
266-
dash_duo.percy_snapshot("devtools - multi output python exception - closed")
266+
dash_duo.percy_snapshot("devtools - multi output Python exception - closed")
267267

268268
dash_duo.find_element(".test-devtools-error-toggle").click()
269-
dash_duo.percy_snapshot("devtools - multi output python exception - open")
269+
dash_duo.percy_snapshot("devtools - multi output Python exception - open")

0 commit comments

Comments
 (0)