Skip to content

Commit 0b5c15c

Browse files
committed
Revert "Add --parallel to percy exec calls & new finalize."
This reverts commit 12fc60a.
1 parent 8e3e6c3 commit 0b5c15c

File tree

5 files changed

+8
-16
lines changed

5 files changed

+8
-16
lines changed

.circleci/config.yml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -533,14 +533,6 @@ jobs:
533533
npm run lint
534534
when: always
535535

536-
percy_finalize:
537-
docker:
538-
- image: cimg/node:16.13-browsers
539-
steps:
540-
- checkout
541-
- run: npm run ci
542-
- run: npx percy build:finalize
543-
544536
workflows:
545537
version: 2
546538
tests:
@@ -596,15 +588,15 @@ workflows:
596588
requires:
597589
- install-dependencies-39
598590

599-
- percy_finalize:
591+
- percy/finalize_all:
600592
requires:
601593
- test-39
602594
- dcc-test-39
603595
- html-python-39
604596
- table-server-test
605597
- artifacts:
606598
requires:
607-
- percy_finalize
599+
- percy/finalize_all
608600
filters:
609601
branches:
610602
only:

components/dash-core-components/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
"private::lint.prettier": "prettier --config .prettierrc src/**/*.js --list-different",
2222
"prepublishOnly": "rm -rf lib && babel src --out-dir lib --copy-files && rm -rf lib/jl/ lib/*.jl",
2323
"test": "run-s -c lint test:intg test:pyimport",
24-
"test:intg": "percy exec --parallel -- pytest --headless tests/integration --reruns 3",
25-
"test:ci": "TESTFILES=$(circleci tests glob \"tests/integration/**/test_*.py\" | circleci tests split --split-by=timings) && percy exec --parallel -- pytest --headless --junitxml=test-reports/junit_intg.xml --junitprefix=\"components.dash-core-components\" ${TESTFILES} --reruns 3",
24+
"test:intg": "percy exec -- pytest --headless tests/integration --reruns 3",
25+
"test:ci": "TESTFILES=$(circleci tests glob \"tests/integration/**/test_*.py\" | circleci tests split --split-by=timings) && percy exec -- pytest --headless --junitxml=test-reports/junit_intg.xml --junitprefix=\"components.dash-core-components\" ${TESTFILES} --reruns 3",
2626
"test:pyimport": "python -m unittest tests/test_dash_import.py",
2727
"prebuild:js": "cp node_modules/plotly.js-dist-min/plotly.min.js dash_core_components_base/plotly.min.js && cp node_modules/mathjax/es5/tex-svg.js dash_core_components_base/mathjax.js",
2828
"build:js": "webpack --mode production",

components/dash-html-components/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"build": "npm run build:js && npm run build:backends",
2222
"postbuild": "es-check es5 dash_html_components/*.js",
2323
"build:watch": "watch 'npm run build' src",
24-
"test:py": "percy exec --parallel -- pytest --headless tests/test_dash_html_components.py tests/test_integration.py",
24+
"test:py": "percy exec -- pytest --headless tests/test_dash_html_components.py tests/test_integration.py",
2525
"test": "run-s -c test:py lint"
2626
},
2727
"author": "Chris Parmer <[email protected]>",

components/dash-table/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
"postbuild": "es-check es5 dash_table/bundle.js dash_table/async-*.js",
3333
"format": "run-s private::format.*",
3434
"lint": "run-s private::lint.*",
35-
"test.server": "percy exec --parallel -- pytest tests/selenium",
36-
"test.ci-server": "TESTFILES=$(circleci tests glob \"tests/selenium/**/test_*.py\" | circleci tests split --split-by=timings) && percy exec --parallel -- pytest --junitxml=test-reports/junit_intg.xml --junitprefix=\"components.dash-table\" ${TESTFILES}",
35+
"test.server": "percy exec -- pytest tests/selenium",
36+
"test.ci-server": "TESTFILES=$(circleci tests glob \"tests/selenium/**/test_*.py\" | circleci tests split --split-by=timings) && percy exec -- pytest --junitxml=test-reports/junit_intg.xml --junitprefix=\"components.dash-table\" ${TESTFILES}",
3737
"test.unit": "run-s private::test.python private::test.unit",
3838
"test.visual": "build-storybook && percy-storybook --widths=1280",
3939
"test.visual-local": "build-storybook"

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"private::test.R.deploy-standard": "npm run private::test.setup-standard && cd \\@plotly/dash-generator-test-component-standard && sudo R CMD INSTALL .",
2424
"private::test.unit-dash": "pytest tests/unit --reruns 3",
2525
"private::test.unit-renderer": "cd dash/dash-renderer && npm run test",
26-
"private::test.integration-dash": "TESTFILES=$(circleci tests glob \"tests/integration/**/test_*.py\" | circleci tests split --split-by=timings) && percy exec --parallel -- pytest --headless --junitxml=test-reports/junit_intg.xml ${TESTFILES} --reruns 3",
26+
"private::test.integration-dash": "TESTFILES=$(circleci tests glob \"tests/integration/**/test_*.py\" | circleci tests split --split-by=timings) && percy exec -- pytest --headless --junitxml=test-reports/junit_intg.xml ${TESTFILES} --reruns 3",
2727
"private::test.integration-dash-import": "cd tests/integration/dash && python dash_import_test.py",
2828
"build": "run-s private::build.*",
2929
"build.sequential": "npm run private::build.renderer && npm run private::build.components -- --concurrency 1",

0 commit comments

Comments
 (0)