added tests

Author: AnnMarieW

dash/__init__.py

@@ -21,8 +21,8 @@
 from .version import __version__  # noqa: F401,E402
 from ._callback_context import callback_context  # noqa: F401,E402
 from ._callback import callback, clientside_callback  # noqa: F401,E402
-from ._get_paths import (
+from ._get_paths import (  # noqa: F401,E402
     get_asset_url,
     get_relative_path,
     strip_relative_path,
-)  # noqa: F401,E402
+)

dash/_get_paths.py

@@ -5,10 +5,10 @@
 
 
 def get_asset_url(path):
-    return real_get_asset_url(CONFIG, path)
+    return app_get_asset_url(CONFIG, path)
 
 
-def real_get_asset_url(config, path):
+def app_get_asset_url(config, path):
     if config.assets_external_path:
         prefix = config.assets_external_path
     else:
@@ -60,10 +60,10 @@ def display_content(path):
             return chapters.page_2
     ```
     """
-    return real_get_relative_path(CONFIG.requests_pathname_prefix, path)
+    return app_get_relative_path(CONFIG.requests_pathname_prefix, path)
 
 
-def real_get_relative_path(requests_pathname, path):
+def app_get_relative_path(requests_pathname, path):
     if requests_pathname == "/" and path == "":
         return "/"
     if requests_pathname != "/" and path == "":
@@ -127,10 +127,10 @@ def display_content(path):
     `page-1/sub-page-1`
     ```
     """
-    return real_strip_relative_path(CONFIG.requests_pathname_prefix, path)
+    return app_strip_relative_path(CONFIG.requests_pathname_prefix, path)
 
 
-def real_strip_relative_path(requests_pathname, path):
+def app_strip_relative_path(requests_pathname, path):
     if path is None:
         return None
     if (

dash/dash.py

@@ -1473,7 +1473,7 @@ def csp_hashes(self, hash_algorithm="sha256"):
         ]
 
     def get_asset_url(self, path):
-        return _get_paths.real_get_asset_url(self.config, path)
+        return _get_paths.app_get_asset_url(self.config, path)
 
     def get_relative_path(self, path):
         """
@@ -1512,7 +1512,9 @@ def display_content(path):
                 return chapters.page_2
         ```
         """
-        return _get_paths.real_get_relative_path(self.config, path)
+        return _get_paths.app_get_relative_path(
+            self.config.requests_pathname_prefix, path
+        )
 
     def strip_relative_path(self, path):
         """
@@ -1561,7 +1563,9 @@ def display_content(path):
         `page-1/sub-page-1`
         ```
         """
-        return _get_paths.real_strip_relative_path(self.config, path)
+        return _get_paths.app_strip_relative_path(
+            self.config.requests_pathname_prefix, path
+        )
 
     def _setup_dev_tools(self, **kwargs):
         debug = kwargs.get("debug", False)

tests/unit/test_configs.py

@@ -16,9 +16,12 @@
 
 from dash._utils import AttributeDict
 from dash._get_paths import (
-    real_get_asset_url,
-    real_get_relative_path,
-    real_strip_relative_path,
+    app_get_asset_url,
+    app_get_relative_path,
+    app_strip_relative_path,
+    get_asset_url,
+    get_relative_path,
+    strip_relative_path,
 )
 
 
@@ -108,7 +111,7 @@ def test_pathname_prefix_environ_requests(empty_environ):
 )
 def test_pathname_prefix_assets(empty_environ, req, expected):
     config = AttributeDict(assets_external_path=req, assets_url_path="assets")
-    path = real_get_asset_url(config, "reset.css")
+    path = app_get_asset_url(config, "reset.css")
     assert path == expected
 
 
@@ -142,8 +145,51 @@ def test_asset_url(
         assets_url_path=assets_url_path,
     )
 
-    path = app.get_asset_url("reset.css")
-    assert path == expected
+    app_path = app.get_asset_url("reset.css")
+    dash_path = get_asset_url("reset.css")
+    assert app_path == dash_path == expected
+
+
+@pytest.mark.parametrize(
+    "requests_pathname_prefix, expected",
+    [
+        (None, "/page2"),
+        ("/app/", "/app/page2"),
+    ],
+)
+def test_get_relative_path(
+    empty_environ,
+    requests_pathname_prefix,
+    expected,
+):
+    app = Dash(
+        "Dash",
+        requests_pathname_prefix=requests_pathname_prefix,
+    )
+    app_path = app.get_relative_path("/page2")
+    dash_path = get_relative_path("/page2")
+    assert app_path == dash_path == expected
+
+
+@pytest.mark.parametrize(
+    "requests_pathname_prefix, expected",
+    [
+        (None, "/app/page2"),
+        ("/app/", "/page2"),
+    ],
+)
+def test_strip_relative_path(
+    empty_environ,
+    requests_pathname_prefix,
+    expected,
+):
+    app = Dash(
+        "Dash",
+        requests_pathname_prefix=requests_pathname_prefix,
+    )
+    app_path = app.strip_relative_path("/app/page2")
+    dash_path = strip_relative_path("/app/page2")
+    assert app_path == dash_path == expected
 
 
 def test_get_combined_config_dev_tools_ui(empty_environ):
@@ -216,7 +262,7 @@ def test_app_name_server(empty_environ, name, server, expected):
     ],
 )
 def test_pathname_prefix_relative_url(prefix, partial_path, expected):
-    path = real_get_relative_path(prefix, partial_path)
+    path = app_get_relative_path(prefix, partial_path)
     assert path == expected
 
 
@@ -226,7 +272,7 @@ def test_pathname_prefix_relative_url(prefix, partial_path, expected):
 )
 def test_invalid_get_relative_path(prefix, partial_path):
     with pytest.raises(_exc.UnsupportedRelativePath):
-        real_get_relative_path(prefix, partial_path)
+        app_get_relative_path(prefix, partial_path)
 
 
 @pytest.mark.parametrize(
@@ -254,7 +300,7 @@ def test_invalid_get_relative_path(prefix, partial_path):
     ],
 )
 def test_strip_relative_path(prefix, partial_path, expected):
-    path = real_strip_relative_path(prefix, partial_path)
+    path = app_strip_relative_path(prefix, partial_path)
     assert path == expected
 
 
@@ -268,7 +314,7 @@ def test_strip_relative_path(prefix, partial_path, expected):
 )
 def test_invalid_strip_relative_path(prefix, partial_path):
     with pytest.raises(_exc.UnsupportedRelativePath):
-        real_strip_relative_path(prefix, partial_path)
+        app_strip_relative_path(prefix, partial_path)
 
 
 def test_port_env_fail_str(empty_environ):