Skip to content

Commit 292ece8

Browse files
committed
rename localizations to labels
1 parent 7f5c5c3 commit 292ece8

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

components/dash-core-components/src/components/Dropdown.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import dropdown from '../utils/LazyLoader/dropdown';
44

55
const RealDropdown = lazy(dropdown);
66

7-
const defaultLocalizations: DropdownProps['localizations'] = {
7+
const defaultLabels: DropdownProps['labels'] = {
88
select_all: 'Select All',
99
deselect_all: 'Deselect All',
1010
selected_count: '{num_selected} selected',
@@ -29,7 +29,7 @@ export default function Dropdown({
2929
disabled = false,
3030
multi = false,
3131
searchable = true,
32-
localizations = defaultLocalizations,
32+
labels = defaultLabels,
3333
optionHeight = 'auto',
3434
// eslint-disable-next-line no-magic-numbers
3535
maxHeight = 200,
@@ -40,17 +40,17 @@ export default function Dropdown({
4040
persistence_type = PersistenceTypes.local,
4141
...props
4242
}: DropdownProps) {
43-
localizations = {
44-
...defaultLocalizations,
45-
...localizations,
43+
labels = {
44+
...defaultLabels,
45+
...labels,
4646
};
4747

4848
return (
4949
<Suspense fallback={null}>
5050
<RealDropdown
5151
clearable={clearable}
5252
disabled={disabled}
53-
localizations={localizations}
53+
labels={labels}
5454
multi={multi}
5555
searchable={searchable}
5656
optionHeight={optionHeight}

components/dash-core-components/src/fragments/Dropdown.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const Dropdown = (props: DropdownProps) => {
2828
closeOnSelect,
2929
clearable,
3030
disabled,
31-
localizations,
31+
labels,
3232
maxHeight,
3333
multi,
3434
options,
@@ -389,7 +389,7 @@ const Dropdown = (props: DropdownProps) => {
389389
id={accessibleId + '-value-count'}
390390
className="dash-dropdown-value-count"
391391
>
392-
{localizations?.selected_count?.replace(
392+
{labels?.selected_count?.replace(
393393
'{num_selected}',
394394
`${sanitizedValues.length}`
395395
)}
@@ -402,8 +402,8 @@ const Dropdown = (props: DropdownProps) => {
402402
e.preventDefault();
403403
handleClear();
404404
}}
405-
title={localizations?.clear_selection}
406-
aria-label={localizations?.clear_selection}
405+
title={labels?.clear_selection}
406+
aria-label={labels?.clear_selection}
407407
>
408408
<Cross1Icon />
409409
</a>
@@ -431,7 +431,7 @@ const Dropdown = (props: DropdownProps) => {
431431
<input
432432
type="search"
433433
className="dash-dropdown-search"
434-
placeholder={localizations?.search}
434+
placeholder={labels?.search}
435435
value={search_value || ''}
436436
autoComplete="off"
437437
onChange={e => onInputChange(e.target.value)}
@@ -442,7 +442,7 @@ const Dropdown = (props: DropdownProps) => {
442442
type="button"
443443
className="dash-dropdown-clear"
444444
onClick={handleClearSearch}
445-
aria-label={localizations?.clear_search}
445+
aria-label={labels?.clear_search}
446446
>
447447
<Cross1Icon />
448448
</button>
@@ -456,15 +456,15 @@ const Dropdown = (props: DropdownProps) => {
456456
className="dash-dropdown-action-button"
457457
onClick={handleSelectAll}
458458
>
459-
{localizations?.select_all}
459+
{labels?.select_all}
460460
</button>
461461
{canDeselectAll && (
462462
<button
463463
type="button"
464464
className="dash-dropdown-action-button"
465465
onClick={handleDeselectAll}
466466
>
467-
{localizations?.deselect_all}
467+
{labels?.deselect_all}
468468
</button>
469469
)}
470470
</div>
@@ -488,7 +488,7 @@ const Dropdown = (props: DropdownProps) => {
488488
{isOpen && search_value && !displayOptions.length && (
489489
<div className="dash-dropdown-options">
490490
<span className="dash-dropdown-option">
491-
{localizations?.no_options_found}
491+
{labels?.no_options_found}
492492
</span>
493493
</div>
494494
)}

components/dash-core-components/src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ export interface DropdownProps extends BaseComponentProps<DropdownProps> {
418418
/**
419419
* Translations for customizing text contained within this component.
420420
*/
421-
localizations?: {
421+
labels?: {
422422
select_all?: string;
423423
deselect_all?: string;
424424
selected_count?: string;

0 commit comments

Comments
 (0)