🐛 add missing useEffect dependency to dcc.Loading component

KoolADE85 · KoolADE85 · commit 29eef59aef17 · 2024-08-22T12:36:23.000-06:00
diff --git a/components/dash-core-components/src/components/Loading.react.js b/components/dash-core-components/src/components/Loading.react.js
@@ -122,7 +122,7 @@ const Loading = ({
                 }
             }
         }
-    }, [delay_hide, delay_show, loading_state, display]);
+    }, [delay_hide, delay_show, loading_state, display, showSpinner]);
 
     const Spinner = showSpinner && getSpinner(spinnerType);
 

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ const Loading = ({`
`122`	`122`	`}`
`123`	`123`	`}`
`124`	`124`	`}`
`125`		`- }, [delay_hide, delay_show, loading_state, display]);`
	`125`	`+ }, [delay_hide, delay_show, loading_state, display, showSpinner]);`
`126`	`126`
`127`	`127`	`const Spinner = showSpinner && getSpinner(spinnerType);`
`128`	`128`