Skip to content

Commit 378099f

Browse files
committed
Merge remote-tracking branch 'dash/dev' into support-async-callbacks
2 parents f1ac667 + 2094f4a commit 378099f

File tree

3 files changed

+38
-2
lines changed

3 files changed

+38
-2
lines changed

.circleci/config.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -540,7 +540,7 @@ jobs:
540540
table-visual-test:
541541
working_directory: ~/dash/components/dash-table
542542
docker:
543-
- image: cimg/node:16.13-browsers
543+
- image: cimg/node:lts-browsers
544544
environment:
545545
PERCY_TOKEN: $PERCY_TOKEN_TABLE
546546

@@ -551,7 +551,6 @@ jobs:
551551
- restore_cache:
552552
key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}
553553
- browser-tools/install-browser-tools:
554-
chrome-version: 120.0.6099.71
555554
install-firefox: false
556555
install-geckodriver: false
557556
- run:

dash/_get_paths.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,13 @@
55

66

77
def get_asset_url(path):
8+
"""
9+
Return the URL for the provided `path` in the assets directory.
10+
11+
`dash.get_asset_url` is not compatible with Dash Snapshots.
12+
Use `get_asset_url` on the app instance instead: `app.get_asset_url`.
13+
See `app.get_asset_url` for more information.
14+
"""
815
return app_get_asset_url(CONFIG, path)
916

1017

@@ -59,6 +66,9 @@ def display_content(path):
5966
if page_name == "page-2":
6067
return chapters.page_2
6168
```
69+
70+
`dash.get_relative_path` is not compatible with Dash Snapshots. Use
71+
`get_relative_path` on the app instance instead: `app.get_relative_path`.
6272
"""
6373
return app_get_relative_path(CONFIG.requests_pathname_prefix, path)
6474

dash/dash.py

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1723,6 +1723,33 @@ def _hash(script):
17231723
]
17241724

17251725
def get_asset_url(self, path):
1726+
"""
1727+
Return the URL for the provided `path` in the assets directory.
1728+
1729+
If `assets_external_path` is set, `get_asset_url` returns
1730+
`assets_external_path` + `assets_url_path` + `path`, where
1731+
`path` is the path passed to `get_asset_url`.
1732+
1733+
Otherwise, `get_asset_url` returns
1734+
`requests_pathname_prefix` + `assets_url_path` + `path`, where
1735+
`path` is the path passed to `get_asset_url`.
1736+
1737+
Use `get_asset_url` in an app to access assets at the correct location
1738+
in different environments. In a deployed app on Dash Enterprise,
1739+
`requests_pathname_prefix` is the app name. For an app called "my-app",
1740+
`app.get_asset_url("image.png")` would return:
1741+
1742+
```
1743+
/my-app/assets/image.png
1744+
```
1745+
1746+
While the same app running locally, without
1747+
`requests_pathname_prefix` set, would return:
1748+
1749+
```
1750+
/assets/image.png
1751+
```
1752+
"""
17261753
return _get_paths.app_get_asset_url(self.config, path)
17271754

17281755
def get_relative_path(self, path):

0 commit comments

Comments
 (0)