grouping for value assignment expression, add test

Author: TillerBurr

dash/testing/wait.py

@@ -62,10 +62,9 @@ def __call__(self, driver):
         try:
             elem = driver.find_element(By.CSS_SELECTOR, self.selector)
             logger.debug("contains text {%s} => expected %s", elem.text, self.text)
-            if value := elem.get_attribute("value") is not None:
+            if (value := elem.get_attribute("value")) is not None:
                 return self.text in str(elem.text) or self.text in str(value)
-            else:
-                return self.text in str(elem.text)
+            return self.text in str(elem.text)
         except WebDriverException:
             return False
 
@@ -108,10 +107,9 @@ def __call__(self, driver):
         try:
             elem = self._get_element(driver)
             logger.debug("text to equal {%s} => expected %s", elem.text, self.text)
-            if value := elem.get_attribute("value") is not None:
+            if (value := elem.get_attribute("value")) is not None:
                 return str(elem.text) == self.text or str(value) == self.text
-            else:
-                return str(elem.text) == self.text
+            return str(elem.text) == self.text
         except WebDriverException:
             return False
 

tests/integration/test_duo.py

@@ -47,3 +47,18 @@ def test_duo001_wait_for_text_error(dash_duo):
         err.value.args[0]
         == "text -> none not found inside element within 1.0s, #none not found"
     )
+
+
+def test_duo002_wait_for_text_value(dash_duo):
+    app = Dash(__name__)
+    app.layout = html.Div([html.Ol([html.Li("Item", id="value-item", value="100")])])
+    dash_duo.start_server(app)
+
+    dash_duo.wait_for_text_to_equal("#value-item", "100")
+    with pytest.raises(TimeoutException) as err:
+        dash_duo.wait_for_contains_text("#value-item", "None", timeout=1.0)
+
+    assert (
+        err.value.args[0]
+        == "text -> None not found inside element within 1.0s, found: Item"
+    )