Skip to content

Commit 3f61e29

Browse files
committed
use npm ci instead of install for clean install
1 parent 8ff71f7 commit 3f61e29

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

.circleci/config.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
set -eo pipefail
5454
pip install -e .[ci,dev,testing,celery,diskcache] --progress-bar off
5555
pip list | grep dash
56-
npm i
56+
npm ci
5757
npm run build
5858
python setup.py sdist
5959
mkdir dash-package && cp dist/*.tar.gz dash-package/dash-package.tar.gz
@@ -111,7 +111,7 @@ jobs:
111111
. venv/bin/activate
112112
set -eo pipefail
113113
pip install -e . --progress-bar off && pip list | grep dash
114-
npm install npm run initialize
114+
npm ci npm run initialize
115115
npm run build
116116
npm run lint
117117
- run:
@@ -181,7 +181,7 @@ jobs:
181181
name: ️️🏗️ Install package
182182
command: |
183183
. venv/bin/activate
184-
npm install
184+
npm ci
185185
pip install dash-package/dash-package.tar.gz[ci,dev,testing,celery,diskcache] --progress-bar off
186186
pip list | grep dash
187187
- run:

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ $ python3 -m venv .venv/dev
1515
$ source .venv/dev/bin/activate
1616
# install dash and dependencies
1717
$ pip install -e .[ci,dev,testing,celery,diskcache] # in some shells you need \ to escape []
18-
$ npm install
18+
$ npm ci
1919
# this script will build the dash-core-components, dash-html-components, dash-table,
2020
# and renderer bundles; this will build all bundles from source code in their
2121
# respective directories. The only true source of npm version is defined

components/dash-core-components/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ $ python -m venv venv && . venv/bin/activate
1818
$ pip install -e .[dev,testing] # in some shells you need \ to escape []
1919

2020
# run the build process - this will build all of dash, including dcc
21-
$ npm i && npm run build
21+
$ npm ci && npm run build
2222

2323
# install dcc in editable mode
2424
$ pip install -e .

components/dash-html-components/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Vanilla HTML components for [Dash][]
1717
```
1818
3. Generate components and install npm packages
1919
```
20-
$ npm install
20+
$ npm ci
2121
```
2222
2323
### Generating HTML Components

dash/development/update_components.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def booststrap_components(components_source):
3131
)
3232

3333
cmd = shlex.split(
34-
"npx lerna exec --scope *@({})* -- npm i".format(source_glob),
34+
"npx lerna exec --scope *@({})* -- npm ci".format(source_glob),
3535
posix=not is_windows,
3636
)
3737

0 commit comments

Comments
 (0)