Merge pull request #3296 from plotly/unsafe-resource-access

T4rk1n · web-flow · commit 419556131b4f · 2025-05-01T16:32:35.000-04:00
Fix unsafe access of 'external_url' field
diff --git a/dash/resources.py b/dash/resources.py
@@ -96,7 +96,7 @@ def _filter_resources(
                 warnings.warn(
                     (
                         "You have set your config to `serve_locally=True` but "
-                        f"A local version of {s['external_url']} is not available.\n"  # type: ignore
+                        f"A local version of {s.get('external_url', '')} is not available.\n"  # type: ignore
                         "If you added this file with "
                         "`app.scripts.append_script` "
                         "or `app.css.append_css`, use `external_scripts` "

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ def _filter_resources(`
`96`	`96`	`warnings.warn(`
`97`	`97`	`(`
`98`	`98`	"You have set your config to `serve_locally=True` but "
`99`		`- f"A local version of {s['external_url']} is not available.\n" # type: ignore`
	`99`	`+ f"A local version of {s.get('external_url', '')} is not available.\n" # type: ignore`
`100`	`100`	`"If you added this file with "`
`101`	`101`	"`app.scripts.append_script` "
`102`	`102`	"or `app.css.append_css`, use `external_scripts` "