Skip to content

Commit 4341a9c

Browse files
authored
Merge pull request #3271 from BSd3v/dev
fixing issue with tooltip styling
2 parents 245249a + 8ca5215 commit 4341a9c

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

components/dash-core-components/src/components/Tooltip.react.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import React from 'react';
22
import PropTypes from 'prop-types';
33

44
import _JSXStyle from 'styled-jsx/style'; // eslint-disable-line no-unused-vars
5-
import LoadingElement from '../utils/LoadingElement';
65

76
/**
87
* A tooltip with an absolute position.
@@ -27,9 +26,9 @@ const Tooltip = ({
2726
return (
2827
<>
2928
<div className="dcc-tooltip-bounding-box">
30-
<LoadingElement
31-
elementType="span"
29+
<div
3230
className={`hover hover-${direction}`}
31+
data-dash-is-loading={is_loading}
3332
>
3433
<span
3534
id={id}
@@ -42,7 +41,7 @@ const Tooltip = ({
4241
props.children
4342
)}
4443
</span>
45-
</LoadingElement>
44+
</div>
4645
</div>
4746
<style jsx>{`
4847
.dcc-tooltip-bounding-box {

components/dash-core-components/tests/integration/graph/test_graph_responsive.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ def update_figures(n_clicks):
205205
dash_dcc.wait_for_text_to_equal("#generate-btn", "Generate Figures")
206206
dash_dcc.find_element("#generate-btn").click()
207207
dash_dcc.wait_for_text_to_equal("#bounding-output", "loaded")
208-
dash_dcc.find_element(".dash-graph .js-plotly-plot.dash-graph--pending")
209-
dash_dcc.find_element(".dash-graph .js-plotly-plot:not(.dash-graph--pending)")
208+
dash_dcc.wait_for_element(".dash-graph .js-plotly-plot.dash-graph--pending")
209+
dash_dcc.wait_for_element(".dash-graph .js-plotly-plot:not(.dash-graph--pending)")
210210
dash_dcc.find_element("#bounding-btn").click()
211211
dash_dcc.wait_for_text_to_equal("#bounding-output", "true")

0 commit comments

Comments
 (0)