Skip to content

Commit 43fe153

Browse files
committed
adjustment for GHA to run the async test
1 parent e82f561 commit 43fe153

File tree

2 files changed

+7
-57
lines changed

2 files changed

+7
-57
lines changed

.circleci/config.yml

Lines changed: 0 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -225,61 +225,6 @@ jobs:
225225
- store_artifacts:
226226
path: /tmp/dash_artifacts
227227

228-
test-312-async: &test
229-
working_directory: ~/dash
230-
docker:
231-
- image: cimg/python:3.12.1-browsers
232-
auth:
233-
username: dashautomation
234-
password: $DASH_PAT_DOCKERHUB
235-
environment:
236-
PERCY_ENABLE: 1
237-
PERCY_PARALLEL_TOTAL: -1
238-
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: True
239-
PYVERSION: python312
240-
REDIS_URL: redis://localhost:6379
241-
- image: cimg/redis:6.2.6
242-
auth:
243-
username: dashautomation
244-
password: $DASH_PAT_DOCKERHUB
245-
parallelism: 3
246-
steps:
247-
- checkout:
248-
path: ~/dash
249-
- run:
250-
name: Add chrome keys & update.
251-
command: |
252-
wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add -
253-
sudo apt-get update
254-
- run: echo $PYVERSION > ver.txt
255-
- run: cat requirements/*.txt > requirements-all.txt
256-
- restore_cache:
257-
key: dep-{{ checksum ".circleci/config.yml" }}-{{ checksum "ver.txt" }}-{{ checksum "requirements-all.txt" }}
258-
- browser-tools/install-browser-tools:
259-
chrome-version: 120.0.6099.71
260-
install-firefox: false
261-
install-geckodriver: false
262-
- attach_workspace:
263-
at: ~/dash
264-
- run:
265-
name: ️️🏗️ Install package
266-
command: |
267-
. venv/bin/activate
268-
npm ci
269-
pip install dash-package/dash-package.tar.gz[async,ci,dev,testing,celery,diskcache] --progress-bar off
270-
pip list | grep dash
271-
- run:
272-
name: 🧪 Run Integration Tests
273-
command: |
274-
. venv/bin/activate
275-
npm run citest.integration
276-
- store_artifacts:
277-
path: test-reports
278-
- store_test_results:
279-
path: test-reports
280-
- store_artifacts:
281-
path: /tmp/dash_artifacts
282-
283228
test-38:
284229
<<: *test
285230
docker:

.github/workflows/testing.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,9 @@ jobs:
135135
run: |
136136
cd tests
137137
pytest compliance/test_typing.py
138-
138+
139139
background-callbacks:
140-
name: Run Background Callback Tests (Python ${{ matrix.python-version }})
140+
name: Run Background & Async Callback Tests (Python ${{ matrix.python-version }})
141141
needs: [build, changes_filter]
142142
if: |
143143
(github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/dev')) ||
@@ -261,6 +261,11 @@ jobs:
261261
touch __init__.py
262262
pytest --headless --nopercyfinalize tests/background_callback -v -s
263263
264+
- name: Run Async Callback Tests
265+
run: |
266+
find packages -name dash-*.whl -print -exec sh -c 'pip install "{}[async]"' \;
267+
pytest --headless --nopercyfinalize -k test_async -v -s
268+
264269
table-unit:
265270
name: Table Unit/Lint Tests (Python ${{ matrix.python-version }})
266271
needs: [build, changes_filter]

0 commit comments

Comments
 (0)