Skip to content

Commit 4e8ca6a

Browse files
committed
Fix unsafe access of newDashVersion
1 parent 915fb58 commit 4e8ca6a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

dash/dash-renderer/src/components/error/menu/VersionInfo.react.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,9 @@ function shouldShowUpgradeNotification(currentDashVersion, newDashVersion) {
7272
const lastDismissed = localStorage.getItem('lastDismissed');
7373
const lastDismissedVersion = localStorage.getItem('lastDismissedVersion');
7474
if (
75-
compareVersions(currentDashVersion, newDashVersion) >=0 ||
76-
showNotifications === 'false' ||
77-
newDashVersion === undefined
75+
newDashVersion === undefined ||
76+
compareVersions(currentDashVersion, newDashVersion) >= 0 ||
77+
showNotifications === 'false'
7878
) {
7979
return false;
8080
} else if (

0 commit comments

Comments
 (0)