Skip to content

Commit 4f75299

Browse files
author
Jody McIntyre
committed
Remove exception logging to reduce test noise
A WebDriverException is frequently raised under normal use of these classes, for example in `text_to_equal()` when the element is not yet part of the page. Example exceptions: ``` ERROR dash.testing.wait:wait.py:95 text_to_equal encountered an exception Traceback (most recent call last): File "/home/circleci/dds/venv/lib/python3.6/site-packages/dash/testing/wait.py", line 91, in __call__ str(elem.text) == self.text File "/home/circleci/dds/venv/lib/python3.6/site-packages/selenium/webdriver/remote/webelement.py", line 76, in text return self._execute(Command.GET_ELEMENT_TEXT)['value'] File "/home/circleci/dds/venv/lib/python3.6/site-packages/selenium/webdriver/remote/webelement.py", line 633, in _execute return self._parent.execute(command, params) File "/home/circleci/dds/venv/lib/python3.6/site-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute self.error_handler.check_response(response) File "/home/circleci/dds/venv/lib/python3.6/site-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response raise exception_class(message, screen, stacktrace) selenium.common.exceptions.StaleElementReferenceException: Message: stale element reference: element is not attached to the page document (Session info: chrome=80.0.3987.132) ``` ``` ERROR dash.testing.wait:wait.py:85 text_to_equal encountered an exception Traceback (most recent call last): File "/home/circleci/dds/venv/lib/python3.6/site-packages/dash/testing/wait.py", line 78, in __call__ elem = driver.find_element_by_css_selector(self.selector) File "/home/circleci/dds/venv/lib/python3.6/site-packages/selenium/webdriver/remote/webdriver.py", line 598, in find_element_by_css_selector return self.find_element(by=By.CSS_SELECTOR, value=css_selector) File "/home/circleci/dds/venv/lib/python3.6/site-packages/selenium/webdriver/remote/webdriver.py", line 978, in find_element 'value': value})['value'] File "/home/circleci/dds/venv/lib/python3.6/site-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute self.error_handler.check_response(response) File "/home/circleci/dds/venv/lib/python3.6/site-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response raise exception_class(message, screen, stacktrace) selenium.common.exceptions.NoSuchElementException: Message: no such element: Unable to locate element: {"method":"css selector","selector":"h1"} (Session info: chrome=80.0.3987.163) ```
1 parent 39bdd8a commit 4f75299

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

dash/testing/wait.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ def __call__(self, driver):
6464
elem.get_attribute("value")
6565
)
6666
except WebDriverException:
67-
logger.exception("contains_text encountered an exception")
6867
return False
6968

7069

@@ -82,7 +81,6 @@ def __call__(self, driver):
8281
or str(elem.get_attribute("value")) == self.text
8382
)
8483
except WebDriverException:
85-
logger.exception("text_to_equal encountered an exception")
8684
return False
8785

8886

@@ -99,5 +97,4 @@ def __call__(self, driver):
9997
logger.debug("style to equal {%s} => expected %s", val, self.val)
10098
return val == self.val
10199
except WebDriverException:
102-
logger.exception("style_to_equal encountered an exception")
103100
return False

0 commit comments

Comments
 (0)