tweak update_components script to exit on all failures

and cleaner formatting

Author: alexcjohnson

dash/development/update_components.py

@@ -42,20 +42,17 @@ def booststrap_components(components_source):
         status = proc.poll()
 
     if err:
-        print(err.decode(), file=sys.stderr)
+        print(("🛑 " if status else "") + err.decode(), file=sys.stderr)
 
-    if status == 0:
+    if status or not out:
         print(
-            "🟢 Finished installing npm dependencies for the following component packages: {} (status={}) 🟢".format(
-                source_glob, status
-            ),
+            "🚨 Failed installing npm dependencies for component packages: {source_glob} (status={status}) 🚨",
             file=sys.stderr,
         )
-    if not out:
+        sys.exit(1)
+    else:
         print(
-            "Failed installing npm dependencies for the following component packages {} (status={})".format(
-                source_glob, status
-            ),
+            f"🟢 Finished installing npm dependencies for component packages: {source_glob} 🟢",
             file=sys.stderr,
         )
 
@@ -82,13 +79,11 @@ def build_components(components_source):
         status = proc.poll()
 
     if err:
-        print(err.decode(), file=sys.stderr)
+        print(("🛑 " if status else "") + err.decode(), file=sys.stderr)
 
-    if not out:
+    if status or not out:
         print(
-            "🟢 Finished updating the following component packages {} (status={}) 🟢".format(
-                source_glob, status
-            ),
+            f"🚨 Finished updating component packages: {source_glob} (status={status}) 🚨",
             file=sys.stderr,
         )
         sys.exit(1)
@@ -117,21 +112,18 @@ def build_components(components_source):
 
         if not os.path.exists(build_directory):
             print(
-                "Could not locate build artifacts. Check that the npm build process completed successfully for the given package: {}".format(
-                    package
-                )
+                "🚨 Could not locate build artifacts."
+                + " Check that the npm build process completed"
+                + f" successfully for package: {package} 🚨"
             )
+            sys.exit(1)
         else:
-            print("🚚 Moving build artifacts from " + build_directory + " to Dash 🚚")
+            print(f"🚚 Moving build artifacts from {build_directory} to Dash 🚚")
             shutil.rmtree(dest_path)
             shutil.copytree(build_directory, dest_path)
             with open(os.path.join(dest_path, ".gitkeep"), "w"):
                 pass
-            print(
-                "🟢 Finished moving build artifacts from "
-                + build_directory
-                + " to Dash 🟢"
-            )
+            print(f"🟢 Finished moving build artifacts from {build_directory} to Dash 🟢")
 
 
 def cli():
@@ -143,7 +135,9 @@ def cli():
     )
     parser.add_argument(
         "components_source",
-        help="A glob string that matches the Dash component libraries to be updated (eg.'dash-table' // 'dash-core-components|dash-html-components' // 'all'). The default argument is 'all'.",
+        help="A glob string that matches the Dash component libraries to be updated"
+        " (eg.'dash-table' // 'dash-core-components|dash-html-components' // 'all')."
+        " The default argument is 'all'.",
         default="all",
     )
 
@@ -153,4 +147,5 @@ def cli():
     build_components(args.components_source)
 
 
-cli()
+if __name__ == "__main__":
+    cli()