Merge pull request #1939 from plotly/use-npm-ci

npm clean-install

Author: alexcjohnson

.circleci/config.yml

@@ -53,7 +53,7 @@ jobs:
             set -eo pipefail
             pip install -e .[ci,dev,testing,celery,diskcache] --progress-bar off
             pip list | grep dash
-            npm i
+            npm ci
             npm run build.sequential
             python setup.py sdist
             mkdir dash-package && cp dist/*.tar.gz dash-package/dash-package.tar.gz
@@ -119,7 +119,7 @@ jobs:
             . venv/bin/activate
             set -eo pipefail
             pip install -e . --progress-bar off && pip list | grep dash
-            npm install npm run initialize
+            npm ci npm run initialize
             npm run build.sequential
             npm run lint
       - run:
@@ -189,7 +189,7 @@ jobs:
           name: ️️🏗️ Install package
           command: |
             . venv/bin/activate
-            npm install
+            npm ci
             pip install dash-package/dash-package.tar.gz[ci,dev,testing,celery,diskcache] --progress-bar off
             pip list | grep dash
       - run:

CONTRIBUTING.md

@@ -15,7 +15,7 @@ $ python3 -m venv .venv/dev
 $ source .venv/dev/bin/activate
 # install dash and dependencies
 $ pip install -e .[ci,dev,testing,celery,diskcache]  # in some shells you need \ to escape []
-$ npm install
+$ npm ci
 # this script will build the dash-core-components, dash-html-components, dash-table,
 # and renderer bundles; this will build all bundles from source code in their
 # respective directories. The only true source of npm version is defined

components/dash-core-components/README.md

@@ -18,7 +18,7 @@ $ python -m venv venv && . venv/bin/activate
 $ pip install -e .[dev,testing]  # in some shells you need \ to escape []
 
 # run the build process - this will build all of dash, including dcc
-$ npm i && npm run build
+$ npm ci && npm run build
 
 # install dcc in editable mode
 $ pip install -e .

components/dash-html-components/README.md

@@ -17,7 +17,7 @@ Vanilla HTML components for [Dash][]
     ```
 3. Generate components and install npm packages
     ```
-    $ npm install
+    $ npm ci
     ```
 
 ### Generating HTML Components

dash/development/update_components.py

@@ -20,7 +20,7 @@ class _CombinedFormatter(
 )
 
 
-def bootstrap_components(components_source, concurrency):
+def bootstrap_components(components_source, concurrency, install_type):
 
     is_windows = sys.platform == "win32"
 
@@ -30,7 +30,7 @@ def bootstrap_components(components_source, concurrency):
         else "dash-core-components|dash-html-components|dash-table"
     )
 
-    cmdstr = f"npx lerna exec --concurrency {concurrency} --scope *@({source_glob})* -- npm i"
+    cmdstr = f"npx lerna exec --concurrency {concurrency} --scope *@({source_glob})* -- npm {install_type}"
     cmd = shlex.split(cmdstr, posix=not is_windows)
     print(cmdstr)
 
@@ -144,10 +144,17 @@ def cli():
         default=3,
         help="Maximum concurrent steps, up to 3 (ie all components in parallel)",
     )
+    parser.add_argument(
+        "--ci",
+        help="For clean-install use '--ci True'",
+        default="False",
+    )
 
     args = parser.parse_args()
 
-    bootstrap_components(args.components_source, args.concurrency)
+    bootstrap_components(
+        args.components_source, args.concurrency, "ci" if args.ci == "True" else "i"
+    )
     build_components(args.components_source, args.concurrency)
 
 

package.json

@@ -6,7 +6,9 @@
     "private::format.renderer": "cd dash/dash-renderer && npm run format",
     "private::format.dcc": "cd components/dash-core-components && npm run format",
     "private::initialize.renderer": "cd dash/dash-renderer && npm ci",
+    "private::cibuild.components": "python dash/development/update_components.py 'all' --ci True",
     "private::build.components": "python dash/development/update_components.py 'all'",
+    "private::cibuild.renderer": "cd dash/dash-renderer && renderer build",
     "private::build.renderer": "cd dash/dash-renderer && renderer build",
     "private::lint.black": "if [[ ${PYVERSION:-python39} != python36 ]]; then black dash tests --exclude metadata_test.py --check; fi",
     "private::lint.flake8": "flake8 --exclude=metadata_test.py dash tests",
@@ -26,6 +28,7 @@
     "private::test.unit-renderer": "cd dash/dash-renderer && npm run test",
     "private::test.integration-dash": "TESTFILES=$(circleci tests glob \"tests/integration/**/test_*.py\" | circleci tests split --split-by=timings) && pytest --headless --nopercyfinalize --junitxml=test-reports/junit_intg.xml ${TESTFILES} --reruns 3",
     "private::test.integration-dash-import": "cd tests/integration/dash && python dash_import_test.py",
+    "cibuild": "run-s private::cibuild.*",
     "build": "run-s private::build.*",
     "build.sequential": "npm run private::build.renderer && npm run private::build.components -- --concurrency 1",
     "format": "run-s private::format.*",