Skip to content

Commit 64ed7fc

Browse files
authored
Merge pull request #2956 from plotly/bugfix/loading-component-missing-dependency
🐛 add missing useEffect dependency to dcc.Loading component
2 parents c4b5540 + 686b1dd commit 64ed7fc

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
1616
- [#2900](https://github.com/plotly/dash/pull/2900) Allow strings in layout list. Fixes [#2890](https://github.com/plotly/dash/issues/2890)
1717
- [#2908](https://github.com/plotly/dash/pull/2908) Fix when environment variables are ignored by Dash.run() at runtime. Fixes [#2902](https://github.com/plotly/dash/issues/2902)
1818
- [#2915](https://github.com/plotly/dash/pull/2915) Fix 'AttributeError' when layout is a function that returns a list of components. Fixes [#2905](https://github.com/plotly/dash/issues/2905)
19+
- [#2956](https://github.com/plotly/dash/pull/2956) Add missing useEffect dependency to dcc.Loading component.
1920

2021
## [2.17.1] - 2024-06-12
2122

components/dash-core-components/src/components/Loading.react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ const Loading = ({
122122
}
123123
}
124124
}
125-
}, [delay_hide, delay_show, loading_state, display]);
125+
}, [delay_hide, delay_show, loading_state, display, showSpinner]);
126126

127127
const Spinner = showSpinner && getSpinner(spinnerType);
128128

0 commit comments

Comments
 (0)