Skip to content

Commit 6bdd256

Browse files
committed
Fix dash-table typescript errors.
1 parent 0d63b0b commit 6bdd256

File tree

6 files changed

+9
-5
lines changed

6 files changed

+9
-5
lines changed

components/dash-table/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

components/dash-table/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@
103103
"sheetclip": "^0.3.0",
104104
"style-loader": "^3.3.3",
105105
"ts-loader": "^9.4.3",
106-
"typescript": "^5.0.4",
106+
"typescript": "^5.3.3",
107107
"webpack": "^5.90.0",
108108
"webpack-cli": "^5.1.4",
109109
"webpack-dev-server": "^4.15.1",

components/dash-table/src/dash-table/components/ControlledTable/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1207,12 +1207,12 @@ export default class ControlledTable extends PureComponent<ControlledTableProps>
12071207
) => {
12081208
const {columns, hidden_columns: base, setProps} = this.props;
12091209

1210-
const ids: string[] = actions.getColumnIds(
1210+
const ids = actions.getColumnIds(
12111211
column,
12121212
columns,
12131213
headerRowIndex,
12141214
mergeDuplicateHeaders
1215-
);
1215+
) as string[];
12161216

12171217
const hidden_columns = base ? base.slice(0) : [];
12181218
ids.forEach(id => {

components/dash-table/src/dash-table/components/Export/utils.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ export async function createWorkbook(
7272

7373
const ws = XLSX.utils.aoa_to_sheet([]);
7474

75+
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
76+
// @ts-ignore
7577
data = R.map(R.pick(columnID))(data);
7678

7779
if (

components/dash-table/src/dash-table/derived/header/content.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ function getter(
418418
hiddenColumns
419419
? R.union(
420420
hiddenColumns,
421-
ids
421+
ids as string[]
422422
)
423423
: ids;
424424

components/dash-table/src/dash-table/derived/style/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@ function convertElement(style: GenericStyle): IConvertedStyle {
103103
}
104104

105105
function convertStyle(style: Style): CSSProperties {
106+
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
107+
// @ts-ignore
106108
return R.reduce<[string, StyleProperty?], any>(
107109
(res, [key, value]) => {
108110
if (converter.has(key)) {

0 commit comments

Comments
 (0)