Skip to content

Commit 6deb92e

Browse files
committed
Fix no ouptut on error & use lts/iron on build windows.
1 parent e9dddc1 commit 6deb92e

File tree

2 files changed

+9
-15
lines changed

2 files changed

+9
-15
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ jobs:
159159
pip install --no-cache-dir --upgrade -e .[ci,dev] --progress-bar off
160160
- run:
161161
command: |
162-
nvm install 18 && nvm use 18
162+
nvm install lts/iron && nvm use lts/iron
163163
- run:
164164
name: npm prereqs
165165
command: |

dash/development/update_components.py

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,12 @@ def bootstrap_components(components_source, concurrency, install_type):
4848
status_print(cmdstr)
4949

5050
with subprocess.Popen(
51-
cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=is_windows
51+
cmd, shell=is_windows
5252
) as proc:
53-
out, err = proc.communicate()
54-
status = proc.poll()
53+
proc.wait()
54+
status = proc.returncode
5555

56-
if err:
57-
status_print(("🛑 " if status else "") + err.decode(), file=sys.stderr)
58-
59-
if status or not out:
56+
if status:
6057
status_print(
6158
f"🚨 Failed installing npm dependencies for component packages: {source_glob} (status={status}) 🚨",
6259
file=sys.stderr,
@@ -84,15 +81,12 @@ def build_components(components_source, concurrency):
8481
status_print(cmdstr)
8582

8683
with subprocess.Popen(
87-
cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=is_windows
84+
cmd, shell=is_windows
8885
) as proc:
89-
out, err = proc.communicate()
90-
status = proc.poll()
91-
92-
if err:
93-
status_print(("🛑 " if status else "") + err.decode(), file=sys.stderr)
86+
proc.wait()
87+
status = proc.returncode
9488

95-
if status or not out:
89+
if status:
9690
status_print(
9791
f"🚨 Finished updating component packages: {source_glob} (status={status}) 🚨",
9892
file=sys.stderr,

0 commit comments

Comments
 (0)