Skip to content

Commit 745f0f3

Browse files
committed
Small changes to address code review feedback
1 parent dd6ed5b commit 745f0f3

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

components/dash-core-components/src/components/Input.react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export default class Input extends PureComponent {
6666
data-dash-is-loading={
6767
(loading_state && loading_state.is_loading) || undefined
6868
}
69-
className={`dash-input ${this.props.className || ''}`}
69+
className={['dash-input', this.props.className].join(' ')}
7070
ref={this.input}
7171
onBlur={this.onBlur}
7272
onChange={this.onChange}

components/dash-core-components/src/components/css/input.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ input.dash-input:invalid {
44

55
input.dash-input:valid {
66
outline: none black;
7-
}
7+
}

components/dash-core-components/tests/integration/input/test_input_basics.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import pytest
22
from selenium.common.exceptions import WebDriverException
3-
from selenium.webdriver.common.by import By
43
from dash import Dash, Input, Output, dcc, html
54

65

@@ -97,8 +96,8 @@ def test_inbs003_styles_are_scoped(dash_dcc):
9796

9897
dash_dcc.start_server(app)
9998

100-
external_input = dash_dcc.driver.find_element(By.ID, "ExternalInput")
101-
dash_input = dash_dcc.driver.find_element(By.CLASS_NAME, "unittest")
99+
external_input = dash_dcc.find_element("#ExternalInput")
100+
dash_input = dash_dcc.find_element(".unittest")
102101

103102
external_outline_css = external_input.value_of_css_property("outline")
104103
dash_outline_css = dash_input.value_of_css_property("outline")

0 commit comments

Comments
 (0)