Skip to content

Commit 79fa356

Browse files
committed
feat: improve type checking in dash/dash.py based on feedback from @T4rk1n
1 parent 449fd22 commit 79fa356

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

dash/dash.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -434,17 +434,17 @@ def __init__( # pylint: disable=too-many-statements
434434
):
435435
_validate.check_obsolete(obsolete)
436436

437-
caller_name = None if name else get_caller_name()
437+
caller_name: str = name if name is not None else get_caller_name()
438438

439439
# We have 3 cases: server is either True (we create the server), False
440440
# (defer server creation) or a Flask app instance (we use their server)
441441
if isinstance(server, flask.Flask):
442442
self.server = server
443443
if name is None:
444-
name = getattr(server, "name", caller_name)
444+
caller_name = getattr(server, "name", caller_name)
445445
elif isinstance(server, bool):
446446
name = name if name else caller_name
447-
self.server = flask.Flask(name) if server else None # type: ignore
447+
self.server = flask.Flask(caller_name) if server else None # type: ignore
448448
else:
449449
raise ValueError("server must be a Flask app or a boolean")
450450

@@ -454,16 +454,16 @@ def __init__( # pylint: disable=too-many-statements
454454

455455
name = cast(str, name) # to satisfy type checking
456456
self.config = AttributeDict(
457-
name=name,
457+
name=caller_name,
458458
assets_folder=os.path.join(
459-
flask.helpers.get_root_path(name), assets_folder
459+
flask.helpers.get_root_path(caller_name), assets_folder
460460
), # type: ignore
461461
assets_url_path=assets_url_path,
462462
assets_ignore=assets_ignore,
463463
assets_external_path=get_combined_config(
464464
"assets_external_path", assets_external_path, ""
465465
),
466-
pages_folder=pages_folder_config(name, pages_folder, use_pages),
466+
pages_folder=pages_folder_config(caller_name, pages_folder, use_pages),
467467
eager_loading=eager_loading,
468468
include_assets_files=get_combined_config(
469469
"include_assets_files", include_assets_files, True

0 commit comments

Comments
 (0)