Merge branch 'plotly:dev' into windows-user-friendly-contribute

Author: aGitForEveryone

CHANGELOG.md

@@ -8,6 +8,11 @@ This project adheres to [Semantic Versioning](https://semver.org/).
 
 - [#2881](https://github.com/plotly/dash/pull/2881) Add outputs_list to window.dash_clientside.callback_context. Fixes [#2877](https://github.com/plotly/dash/issues/2877).
 
+## Fixed
+
+- [#2892](https://github.com/plotly/dash/pull/2860) Fix ensures dcc.Dropdown menu maxHeight option works with Datatable. Fixes [#2529](https://github.com/plotly/dash/issues/2529) [#2225](https://github.com/plotly/dash/issues/2225)
+- [#2896](https://github.com/plotly/dash/pull/2896) The tabIndex parameter of Div can accept number or string type. Fixes [#2891](https://github.com/plotly/dash/issues/2891)
+
 ## [2.17.1] - 2024-06-12
 
 ## Fixed

components/dash-core-components/src/components/Loading.react.js

@@ -24,6 +24,7 @@ const Loading = ({
     loading_state,
     display,
     color,
+    id,
     className,
     style,
     parent_className,
@@ -144,7 +145,7 @@ const Loading = ({
             >
                 {children}
             </div>
-            <div style={showSpinner ? coveringSpinner : {}}>
+            <div id={id} style={showSpinner ? coveringSpinner : {}}>
                 {showSpinner &&
                     (custom_spinner || (
                         <Spinner

components/dash-core-components/src/components/css/Dropdown.css

@@ -1,7 +1,8 @@
 .dash-dropdown .Select-menu-outer {
     z-index: 1000;
+    max-height: none;
 }
 
-.dash-dropdown .Select-menu, .Select-menu-outer {
+.dash-dropdown .Select-menu {
     max-height: none;
 }

components/dash-core-components/tests/integration/dropdown/test_visibility.py

@@ -50,7 +50,10 @@ def test_ddvi001_fixed_table(dash_duo):
 def test_ddvi002_maxHeight(dash_duo):
     app = Dash(__name__)
     app.layout = Div(
-        [Dropdown([str(i) for i in range(100)], "1", id="dropdown", maxHeight=800)]
+        [
+            DataTable(),  # ensure datatable css does not override maxHeight #2529
+            Dropdown([str(i) for i in range(100)], "1", id="dropdown", maxHeight=800),
+        ]
     )
 
     dash_duo.start_server(app)

components/dash-core-components/tests/integration/loading/test_loading_component.py

@@ -10,7 +10,8 @@ def test_ldcp001_loading_component_initialization(dash_dcc):
     app = Dash(__name__)
 
     app.layout = html.Div(
-        [dcc.Loading([html.Div(id="div-1")], className="loading")], id="root"
+        [dcc.Loading([html.Div(id="div-1")], id="loading", className="loading")],
+        id="root",
     )
 
     @app.callback(Output("div-1", "children"), [Input("root", "n_clicks")])
@@ -20,7 +21,7 @@ def updateDiv(children):
 
     with lock:
         dash_dcc.start_server(app)
-        dash_dcc.find_element(".loading .dash-spinner")
+        dash_dcc.find_element("#loading .loading .dash-spinner")
         # ensure inner component is also mounted
         dash_dcc.wait_for_text_to_equal("#div-1", "")
 

components/dash-html-components/scripts/generate-components.js

@@ -56,7 +56,8 @@ const NUMERIC_PROPERTIES = [
     'cols',
     'colSpan',
     'size',
-    'step'
+    'step',
+    'tabIndex'
 ];
 
 const PROP_TYPES = {

components/dash-html-components/tests/test_div_tabIndex.py

@@ -0,0 +1,53 @@
+from dash import Dash, Input, Output, State, html
+
+
+def test_dt001_div_tabindex_accept_string_and_number_type(dash_duo):
+    app = Dash(__name__)
+    app.layout = html.Div(
+        [
+            html.Div(id="string-div", tabIndex="1"),
+            html.Div(id="number-div", tabIndex=1),
+            html.Button("string", id="trigger-string"),
+            html.Button("number", id="trigger-number"),
+            html.Pre(id="output-string-result"),
+            html.Pre(id="output-number-result"),
+        ],
+        style={"padding": 50},
+    )
+
+    @app.callback(
+        Output("output-string-result", "children"),
+        Input("trigger-string", "n_clicks"),
+        State("string-div", "tabIndex"),
+        prevent_initial_call=True,
+    )
+    def show_div_tabindex_string_type(n_clicks, tabindex):
+        if n_clicks:
+            if isinstance(tabindex, str):
+                return "success"
+        return "fail"
+
+    @app.callback(
+        Output("output-number-result", "children"),
+        Input("trigger-number", "n_clicks"),
+        State("number-div", "tabIndex"),
+        prevent_initial_call=True,
+    )
+    def show_div_tabindex_number_type(n_clicks, tabindex):
+        if n_clicks:
+            if isinstance(tabindex, int):
+                return "success"
+        return "fail"
+
+    dash_duo.start_server(app)
+
+    dash_duo.wait_for_element("#trigger-string").click()
+    dash_duo.wait_for_element("#trigger-number").click()
+    dash_duo.wait_for_text_to_equal(
+        "#output-string-result",
+        "success",
+    )
+    dash_duo.wait_for_text_to_equal(
+        "#output-number-result",
+        "success",
+    )