Skip to content

Commit 8998a33

Browse files
committed
Fix dcc.Loading spinner style
1 parent ba5e2ab commit 8998a33

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

components/dash-core-components/src/components/Loading.react.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import DefaultSpinner from '../fragments/Loading/spinners/DefaultSpinner.jsx';
55
import CubeSpinner from '../fragments/Loading/spinners/CubeSpinner.jsx';
66
import CircleSpinner from '../fragments/Loading/spinners/CircleSpinner.jsx';
77
import DotSpinner from '../fragments/Loading/spinners/DotSpinner.jsx';
8-
import {mergeRight} from 'ramda';
98

109
const spinnerComponentOptions = {
1110
graph: GraphSpinner,
@@ -49,10 +48,6 @@ const Loading = ({
4948
justifyContent: 'center',
5049
alignItems: 'center',
5150
};
52-
const hiddenContainer = mergeRight(
53-
{visibility: 'hidden', position: 'relative'},
54-
overlay_style
55-
);
5651

5752
/* Overrides default Loading behavior if target_components is set. By default,
5853
* Loading fires when any recursive child enters loading state. This makes loading
@@ -135,11 +130,17 @@ const Loading = ({
135130
className={parent_className}
136131
style={
137132
showSpinner
138-
? mergeRight(hiddenContainer, parent_style)
133+
? {position: 'relative', ...parent_style}
139134
: parent_style
140135
}
141136
>
142-
{children}
137+
<div
138+
style={
139+
showSpinner ? {visibility: 'hidden', ...overlay_style} : {}
140+
}
141+
>
142+
{children}
143+
</div>
143144
<div style={showSpinner ? coveringSpinner : {}}>
144145
{showSpinner &&
145146
(custom_spinner || (

0 commit comments

Comments
 (0)