Skip to content

Commit 9c9749f

Browse files
committed
some refinements
1 parent c7337ad commit 9c9749f

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

components/dash-core-components/src/components/Dropdown.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export default function Dropdown({
2323
optionHeight = 36,
2424
// eslint-disable-next-line no-magic-numbers
2525
maxHeight = 200,
26-
closeOnSelect = true,
26+
closeOnSelect = !multi,
2727
// eslint-disable-next-line @typescript-eslint/no-unused-vars
2828
persisted_props = [PersistedProps.value],
2929
// eslint-disable-next-line @typescript-eslint/no-unused-vars

components/dash-core-components/src/components/css/dropdown.css

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
.dash-dropdown {
2+
box-sizing: border-box;
23
margin: calc(var(--Dash-Spacing) * 2) 0;
34
}
45

@@ -30,7 +31,8 @@
3031
background: inherit;
3132
padding: 6px 12px;
3233
width: 100%;
33-
height: 32px;
34+
min-height: 32px;
35+
height: 100%;
3436
cursor: pointer;
3537
font-size: inherit;
3638
overflow: hidden;
@@ -69,6 +71,7 @@
6971
.dash-dropdown-value-count,
7072
.dash-dropdown-trigger-icon {
7173
color: var(--Dash-Text-Strong);
74+
fill: var(--Dash-Text-Strong);
7275
white-space: nowrap;
7376
justify-self: end;
7477
}

components/dash-core-components/src/fragments/Dropdown.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -468,6 +468,8 @@ const Dropdown = (props: DropdownProps) => {
468468
e.preventDefault();
469469
handleClear();
470470
}}
471+
title="Clear selection"
472+
aria-label="Clear selection"
471473
>
472474
<Cross1Icon />
473475
</a>

0 commit comments

Comments
 (0)