Skip to content

Commit a076cdd

Browse files
authored
Merge pull request #3318 from plotly/add-testing-timeout
Add testing timeout
2 parents ed57bb0 + 73a8063 commit a076cdd

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

.github/workflows/testing.yml

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ jobs:
1616
outputs:
1717
# This output will be 'true' if files in the 'table_related_paths' list changed, 'false' otherwise.
1818
table_paths_changed: ${{ steps.filter.outputs.table_related_paths }}
19+
background_cb_changed: ${{ steps.filter.outputs.background_paths }}
1920
steps:
2021
- name: Checkout repository
2122
uses: actions/checkout@v4
@@ -24,15 +25,21 @@ jobs:
2425
id: filter # Give an ID to this step to reference its outputs
2526
uses: dorny/paths-filter@v3
2627
with:
27-
base: ${{ github.ref }}
2828
filters: |
2929
table_related_paths:
3030
- 'components/dash-table/**'
3131
- 'dash/dash-renderer/**'
32+
background_paths:
33+
- 'dash/background_callback/**'
34+
- 'dash/dash-renderer/**'
35+
- 'dash/_callback.py'
36+
- 'dash/_callback_context.py'
37+
- 'requirements/**'
3238
3339
build:
3440
name: Build Dash Package
3541
runs-on: ubuntu-latest
42+
timeout-minutes: 30
3643
outputs:
3744
artifact_name: dash-packages
3845
steps:
@@ -86,6 +93,7 @@ jobs:
8693
name: Typing Tests
8794
runs-on: ubuntu-latest
8895
needs: build
96+
timeout-minutes: 30
8997
strategy:
9098
fail-fast: false
9199

@@ -130,7 +138,11 @@ jobs:
130138
131139
background-callbacks:
132140
name: Run Background Callback Tests (Python ${{ matrix.python-version }})
133-
needs: build
141+
needs: [build, changes_filter]
142+
if: |
143+
(github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/dev')) ||
144+
needs.changes_filter.outputs.background_cb_changed == 'true'
145+
timeout-minutes: 30
134146
runs-on: ubuntu-latest
135147
strategy:
136148
fail-fast: false
@@ -251,8 +263,12 @@ jobs:
251263
252264
table-unit:
253265
name: Table Unit/Lint Tests (Python ${{ matrix.python-version }})
254-
needs: build
266+
needs: [build, changes_filter]
267+
if: |
268+
(github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/dev')) ||
269+
needs.changes_filter.outputs.table_paths_changed == 'true'
255270
runs-on: ubuntu-latest
271+
timeout-minutes: 30
256272
strategy:
257273
fail-fast: false
258274
matrix:
@@ -309,6 +325,7 @@ jobs:
309325
(github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/dev')) ||
310326
needs.changes_filter.outputs.table_paths_changed == 'true'
311327
runs-on: ubuntu-latest
328+
timeout-minutes: 30
312329
strategy:
313330
fail-fast: false
314331
matrix:

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
lts/iron

0 commit comments

Comments
 (0)