Skip to content

Commit a7866b7

Browse files
committed
changed where id is stringified
1 parent fc4f620 commit a7866b7

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

components/dash-core-components/src/components/Loading.react.js

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,6 @@ import CubeSpinner from '../fragments/Loading/spinners/CubeSpinner.jsx';
88
import CircleSpinner from '../fragments/Loading/spinners/CircleSpinner.jsx';
99
import DotSpinner from '../fragments/Loading/spinners/DotSpinner.jsx';
1010

11-
const stringifyId = id => {
12-
if (typeof id !== 'object') {
13-
return id;
14-
}
15-
const stringifyVal = v => (v && v.wild) || JSON.stringify(v);
16-
const parts = Object.keys(id)
17-
.sort()
18-
.map(k => JSON.stringify(k) + ':' + stringifyVal(id[k]));
19-
return '{' + parts.join(',') + '}';
20-
};
21-
2211
const spinnerComponentOptions = {
2312
graph: GraphSpinner,
2413
cube: CubeSpinner,
@@ -51,7 +40,7 @@ const loadingSelector = (componentPath, targetComponents) => state => {
5140
if (
5241
targetComponents &&
5342
!any(l => {
54-
const target = targetComponents[stringifyId(l.id)];
43+
const target = targetComponents[l.id];
5544
if (!target) {
5645
return false;
5746
}

dash/dash-renderer/src/actions/callbacks.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -753,7 +753,7 @@ export function executeCallback(
753753
const loadingOutputs = outputs.map(out => ({
754754
path: getPath(paths, out.id),
755755
property: out.property?.split('@')[0],
756-
id: out.id
756+
id: (window as any).dash_component_api.stringifyId(out.id)
757757
}));
758758
dispatch(loading(loadingOutputs));
759759
try {

0 commit comments

Comments
 (0)