3.6.9 | 3.7.6 (#1290)

Author: Marc-Andre-Rivet

.circleci/config.yml

@@ -10,7 +10,7 @@ jobs:
 
   artifacts:
     docker:
-      - image: circleci/python:3.7-stretch-node-browsers
+      - image: circleci/python:3.7.6-stretch-node-browsers
         environment:
           PYVERSION: python37
     steps:
@@ -27,7 +27,7 @@ jobs:
   lint-unit-37: &lint-unit
     working_directory: ~/dash
     docker:
-      - image: circleci/python:3.7-stretch-node-browsers
+      - image: circleci/python:3.7.6-stretch-node-browsers
         environment:
           PYLINTRC: .pylintrc37
           PYVERSION: python37
@@ -64,7 +64,7 @@ jobs:
   lint-unit-36:
       <<: *lint-unit
       docker:
-        - image: circleci/python:3.6-stretch-node-browsers
+        - image: circleci/python:3.6.9-stretch-node-browsers
           environment:
             PYLINTRC: .pylintrc
             PYVERSION: python36
@@ -80,7 +80,7 @@ jobs:
   build-core-37: &build-core
     working_directory: ~/dash
     docker:
-      - image: circleci/python:3.7-stretch-node-browsers
+      - image: circleci/python:3.7.6-stretch-node-browsers
         environment:
           PYVERSION: python37
     steps:
@@ -115,7 +115,7 @@ jobs:
   build-core-36:
       <<: *build-core
       docker:
-        - image: circleci/python:3.6-stretch-node-browsers
+        - image: circleci/python:3.6.9-stretch-node-browsers
           environment:
             PYVERSION: python36
 
@@ -129,7 +129,7 @@ jobs:
   build-misc-37: &build-misc
     working_directory: ~/dash
     docker:
-      - image: circleci/python:3.7-stretch-node-browsers
+      - image: circleci/python:3.7.6-stretch-node-browsers
         environment:
           PYVERSION: python37
 
@@ -165,7 +165,7 @@ jobs:
   build-misc-36:
       <<: *build-misc
       docker:
-        - image: circleci/python:3.6-stretch-node-browsers
+        - image: circleci/python:3.6.9-stretch-node-browsers
           environment:
             PYVERSION: python36
 
@@ -240,7 +240,7 @@ jobs:
             cd dash-html-components; npm ci && npm run build; rm -rf !(.|..|DESCRIPTION|LICENSE.txt|LICENSE|NAMESPACE|.Rbuildignore|R|man|inst|vignettes|build)
             cd ../dash-core-components; npm ci && npm run build; rm -rf !(.|..|DESCRIPTION|LICENSE.txt|LICENSE|NAMESPACE|.Rbuildignore|R|man|inst|vignettes|build)
             cd ../dash-table; npm ci && npm run build; rm -rf !(.|..|DESCRIPTION|LICENSE.txt|LICENSE|NAMESPACE|.Rbuildignore|R|man|inst|vignettes|build); cd ..
-            
+
       - run:
           name: 🔧fix up dash metadata
           command: |
@@ -286,7 +286,7 @@ jobs:
             Rscript -e "message(devtools::check_failures(path = '${DHC_CHECK_DIR}'))"
             Rscript -e "message(devtools::check_failures(path = '${DCC_CHECK_DIR}'))"
             Rscript -e "message(devtools::check_failures(path = '${DT_CHECK_DIR}'))"
-            Rscript -e "message(devtools::check_failures(path = '${DASH_CHECK_DIR}'))"                                    
+            Rscript -e "message(devtools::check_failures(path = '${DASH_CHECK_DIR}'))"
             # warnings are errors; enable for stricter checks once CRAN submission finished
             # if grep -q -R "WARNING" "${DHC_CHECK_DIR}/00check.log"; then exit 1; fi
             # if grep -q -R "WARNING" "${DCC_CHECK_DIR}/00check.log"; then exit 1; fi
@@ -317,13 +317,13 @@ jobs:
       - run:
           name: 🦔 percy finalize
           command: npx percy finalize --all
-          when: on_fail 
+          when: on_fail
 
 
   test-37: &test
     working_directory: ~/dash
     docker:
-      - image: circleci/python:3.7-stretch-node-browsers
+      - image: circleci/python:3.7.6-stretch-node-browsers
         environment:
           PERCY_PARALLEL_TOTAL: -1
           PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: True
@@ -365,7 +365,7 @@ jobs:
   test-36:
       <<: *test
       docker:
-        - image: circleci/python:3.6-stretch-node-browsers
+        - image: circleci/python:3.6.9-stretch-node-browsers
           environment:
             PERCY_ENABLE: 0
             PYVERSION: python36

dash/testing/application_runners.py

@@ -222,8 +222,7 @@ def stop(self):
                 logger.info("proc.terminate with pid %s", self.proc.pid)
                 self.proc.terminate()
                 if self.tmp_app_path and os.path.exists(self.tmp_app_path):
-                    logger.debug("removing temporary app path %s",
-                                 self.tmp_app_path)
+                    logger.debug("removing temporary app path %s", self.tmp_app_path)
                     shutil.rmtree(self.tmp_app_path)
                 if utils.PY3:
                     # pylint:disable=no-member
@@ -343,7 +342,9 @@ def start(self, app, start_timeout=2, cwd=None):
 
 class JuliaRunner(ProcessRunner):
     def __init__(self, keep_open=False, stop_timeout=3):
-        super(JuliaRunner, self).__init__(keep_open=keep_open, stop_timeout=stop_timeout)
+        super(JuliaRunner, self).__init__(
+            keep_open=keep_open, stop_timeout=stop_timeout
+        )
         self.proc = None
 
     # pylint: disable=arguments-differ
@@ -385,7 +386,9 @@ def start(self, app, start_timeout=30, cwd=None):
                         logger.warning("get cwd from inspect => %s", cwd)
                         break
             if cwd:
-                logger.info("JuliaRunner inferred cwd from the Python call stack: %s", cwd)
+                logger.info(
+                    "JuliaRunner inferred cwd from the Python call stack: %s", cwd
+                )
 
                 # try copying all valid sub folders (i.e. assets) in cwd to tmp
                 # note that the R assets folder name can be any valid folder name
@@ -415,8 +418,7 @@ def start(self, app, start_timeout=30, cwd=None):
         logger.info("Run Dash.jl app with julia => %s", app)
 
         args = shlex.split(
-            "julia {}".format(os.path.realpath(app)),
-            posix=not self.is_windows,
+            "julia {}".format(os.path.realpath(app)), posix=not self.is_windows,
         )
         logger.debug("start Dash.jl process with %s", args)
 

dash/testing/plugin.py

@@ -4,7 +4,12 @@
 
 
 try:
-    from dash.testing.application_runners import ThreadedRunner, ProcessRunner, RRunner, JuliaRunner
+    from dash.testing.application_runners import (
+        ThreadedRunner,
+        ProcessRunner,
+        RRunner,
+        JuliaRunner,
+    )
     from dash.testing.browser import Browser
     from dash.testing.composite import DashComposite, DashRComposite, DashJuliaComposite
 except ImportError:

tests/integration/devtools/test_hot_reload.py

@@ -20,9 +20,7 @@
 
 
 def replace_file(filename, new_content):
-    path = os.path.join(
-        os.path.dirname(__file__), "hr_assets", filename
-    )
+    path = os.path.join(os.path.dirname(__file__), "hr_assets", filename)
     with open(path, "r+") as fp:
         sleep(1)  # ensure a new mod time
         old_content = fp.read()
@@ -92,7 +90,7 @@ def new_text(n):
     try:
         until(
             lambda: dash_duo.driver.execute_script("return window.cheese") == "gouda",
-            timeout=3
+            timeout=3,
         )
     finally:
         sleep(1)  # ensure a new mod time
@@ -101,7 +99,7 @@ def new_text(n):
 
     until(
         lambda: dash_duo.driver.execute_script("return window.cheese") == "roquefort",
-        timeout=3
+        timeout=3,
     )
 
     # we've done a hard reload so someVar is gone