Skip to content

Commit b21410d

Browse files
committed
Fix run host port arguments
1 parent 9140d3a commit b21410d

File tree

1 file changed

+26
-24
lines changed

1 file changed

+26
-24
lines changed

dash/dash.py

Lines changed: 26 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2007,23 +2007,23 @@ def delete_resource(resources):
20072007

20082008
def run(
20092009
self,
2010-
host="127.0.0.1",
2011-
port="8050",
2012-
proxy=None,
2013-
debug=None,
2010+
host: Optional[str] = None,
2011+
port: Optional[str] = None,
2012+
proxy: Optional[str] = None,
2013+
debug: Optional[bool] = None,
20142014
jupyter_mode: Optional[JupyterDisplayMode] = None,
2015-
jupyter_width="100%",
2016-
jupyter_height=650,
2017-
jupyter_server_url=None,
2018-
dev_tools_ui=None,
2019-
dev_tools_props_check=None,
2020-
dev_tools_serve_dev_bundles=None,
2021-
dev_tools_hot_reload=None,
2022-
dev_tools_hot_reload_interval=None,
2023-
dev_tools_hot_reload_watch_interval=None,
2024-
dev_tools_hot_reload_max_retry=None,
2025-
dev_tools_silence_routes_logging=None,
2026-
dev_tools_prune_errors=None,
2015+
jupyter_width: str = "100%",
2016+
jupyter_height: int = 650,
2017+
jupyter_server_url: Optional[str] = None,
2018+
dev_tools_ui: Optional[bool] = None,
2019+
dev_tools_props_check: Optional[bool] = None,
2020+
dev_tools_serve_dev_bundles: Optional[bool] = None,
2021+
dev_tools_hot_reload: Optional[bool] = None,
2022+
dev_tools_hot_reload_interval: Optional[int] = None,
2023+
dev_tools_hot_reload_watch_interval: Optional[int] = None,
2024+
dev_tools_hot_reload_max_retry: Optional[int] = None,
2025+
dev_tools_silence_routes_logging: Optional[bool] = None,
2026+
dev_tools_prune_errors: Optional[bool] = None,
20272027
**flask_run_options,
20282028
):
20292029
"""Start the flask server in local mode, you should not run this on a
@@ -2032,11 +2032,11 @@ def run(
20322032
If a parameter can be set by an environment variable, that is listed
20332033
too. Values provided here take precedence over environment variables.
20342034
2035-
:param host: Host IP used to serve the application
2035+
:param host: Host IP used to serve the application, default to "127.0.0.1"
20362036
env: ``HOST``
20372037
:type host: string
20382038
2039-
:param port: Port used to serve the application
2039+
:param port: Port used to serve the application, default to "8050"
20402040
env: ``PORT``
20412041
:type port: int
20422042
@@ -2137,14 +2137,14 @@ def run(
21372137

21382138
# Evaluate the env variables at runtime
21392139

2140-
host = host or os.getenv("HOST")
2141-
port = port or os.getenv("PORT")
2140+
host = host or os.getenv("HOST", "127.0.0.1")
2141+
port = port or os.getenv("PORT", "8050")
21422142
proxy = proxy or os.getenv("DASH_PROXY")
21432143

21442144
# Verify port value
21452145
try:
2146-
port = int(port)
2147-
assert port in range(1, 65536)
2146+
server_port = int(port)
2147+
assert server_port in range(1, 65536)
21482148
except Exception as e:
21492149
e.args = (f"Expecting an integer from 1 to 65535, found port={repr(port)}",)
21502150
raise
@@ -2203,11 +2203,13 @@ def verify_url_part(served_part, url_part, part_name):
22032203
width=jupyter_width,
22042204
height=jupyter_height,
22052205
host=host,
2206-
port=port,
2206+
port=server_port,
22072207
server_url=jupyter_server_url,
22082208
)
22092209
else:
2210-
self.server.run(host=host, port=port, debug=debug, **flask_run_options)
2210+
self.server.run(
2211+
host=host, port=server_port, debug=debug, **flask_run_options
2212+
)
22112213

22122214
def enable_pages(self):
22132215
if not self.use_pages:

0 commit comments

Comments
 (0)