Skip to content

Commit c2cd4a2

Browse files
authored
Merge pull request #3164 from plotly/fix-bg-typing
Minors fixes 3.0.0rc2
2 parents 09dc4a9 + 71cbc06 commit c2cd4a2

File tree

11 files changed

+20
-15
lines changed

11 files changed

+20
-15
lines changed

components/dash-core-components/src/fragments/DatePickerRange.react.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {DateRangePicker} from 'react-dates';
33
import React, {Component} from 'react';
44
import uniqid from 'uniqid';
55

6-
import {propTypes, defaultProps} from '../components/DatePickerRange.react';
6+
import {propTypes} from '../components/DatePickerRange.react';
77
import convertToMoment from '../utils/convertToMoment';
88
import LoadingElement from '../utils/LoadingElement';
99

@@ -219,4 +219,3 @@ export default class DatePickerRange extends Component {
219219
}
220220

221221
DatePickerRange.propTypes = propTypes;
222-
DatePickerRange.defaultProps = defaultProps;

components/dash-core-components/src/fragments/DatePickerSingle.react.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {SingleDatePicker} from 'react-dates';
44
import moment from 'moment';
55
import React, {Component} from 'react';
66

7-
import {propTypes, defaultProps} from '../components/DatePickerSingle.react';
7+
import {propTypes} from '../components/DatePickerSingle.react';
88
import convertToMoment from '../utils/convertToMoment';
99
import LoadingElement from '../utils/LoadingElement';
1010

@@ -155,4 +155,3 @@ export default class DatePickerSingle extends Component {
155155
}
156156

157157
DatePickerSingle.propTypes = propTypes;
158-
DatePickerSingle.defaultProps = defaultProps;

components/dash-core-components/src/fragments/Markdown.react.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import RemarkMath from 'remark-math';
66

77
import Math from './Math.react';
88
import MarkdownHighlighter from '../utils/MarkdownHighlighter';
9-
import {propTypes, defaultProps} from '../components/Markdown.react';
9+
import {propTypes} from '../components/Markdown.react';
1010

1111
import DccLink from './../components/Link.react';
1212
import LoadingElement from '../utils/LoadingElement';
@@ -187,4 +187,3 @@ export default class DashMarkdown extends Component {
187187
}
188188

189189
DashMarkdown.propTypes = propTypes;
190-
DashMarkdown.defaultProps = defaultProps;

components/dash-core-components/src/fragments/RangeSlider.react.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
calcStep,
1111
setUndefined,
1212
} from '../utils/computeSliderMarkers';
13-
import {propTypes, defaultProps} from '../components/RangeSlider.react';
13+
import {propTypes} from '../components/RangeSlider.react';
1414
import {
1515
formatSliderTooltip,
1616
transformSliderTooltip,
@@ -152,4 +152,3 @@ export default class RangeSlider extends Component {
152152
}
153153

154154
RangeSlider.propTypes = propTypes;
155-
RangeSlider.defaultProps = defaultProps;

components/dash-core-components/src/fragments/Slider.react.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
calcStep,
1111
setUndefined,
1212
} from '../utils/computeSliderMarkers';
13-
import {propTypes, defaultProps} from '../components/Slider.react';
13+
import {propTypes} from '../components/Slider.react';
1414
import {
1515
formatSliderTooltip,
1616
transformSliderTooltip,
@@ -152,4 +152,3 @@ export default class Slider extends Component {
152152
}
153153

154154
Slider.propTypes = propTypes;
155-
Slider.defaultProps = defaultProps;

components/dash-core-components/src/fragments/Upload.react.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React, {Component} from 'react';
22
import Dropzone from 'react-dropzone';
33

4-
import {propTypes, defaultProps} from '../components/Upload.react';
4+
import {propTypes} from '../components/Upload.react';
55
import LoadingElement from '../utils/LoadingElement';
66

77
export default class Upload extends Component {
@@ -91,4 +91,3 @@ export default class Upload extends Component {
9191
}
9292

9393
Upload.propTypes = propTypes;
94-
Upload.defaultProps = defaultProps;

components/dash-core-components/tests/integration/graph/test_graph_varia.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
from selenium.webdriver.support.ui import WebDriverWait
1616
from selenium.webdriver.support import expected_conditions as EC
1717

18+
from flaky import flaky
19+
1820

1921
@pytest.mark.parametrize("is_eager", [True, False])
2022
def test_grva001_candlestick(dash_dcc, is_eager):
@@ -681,6 +683,7 @@ def load_chart(n_clicks):
681683
assert dash_dcc.get_logs() == []
682684

683685

686+
@flaky(max_runs=3)
684687
def test_grva008_shapes_not_lost(dash_dcc):
685688
# See issue #879 and pr #905
686689
app = Dash(__name__)

components/dash-table/tests/selenium/test_navigation.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from selenium.webdriver.common.keys import Keys
77

88
import pytest
9+
import flaky
910

1011
DATA_SIZE = 50
1112

@@ -154,6 +155,7 @@ def test_navg002_keyboard_after_ctrl_copy(test, props):
154155
assert test.get_log_errors() == []
155156

156157

158+
@flaky.flaky(max_runs=3)
157159
@pytest.mark.parametrize("props", [get_markdown_table(), get_mixed_markdown_table()])
158160
@pytest.mark.parametrize(
159161
"key,row,col",

dash/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ def _jupyter_nbextension_paths():
6161
"Input",
6262
"Output",
6363
"State",
64+
"clientside_callback",
6465
"ClientsideFunction",
6566
"MATCH",
6667
"ALLSMALLER",
@@ -88,4 +89,5 @@ def _jupyter_nbextension_paths():
8889
"Patch",
8990
"jupyter_dash",
9091
"ctx",
92+
"hooks",
9193
]

dash/_callback.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,10 @@ def callback(
6868
*_args,
6969
background: bool = False,
7070
interval: int = 1000,
71-
progress: Optional[Output] = None,
71+
progress: Optional[Union[List[Output], Output]] = None,
7272
progress_default: Any = None,
7373
running: Optional[List[Tuple[Output, Any, Any]]] = None,
74-
cancel: Optional[List[Input]] = None,
74+
cancel: Optional[Union[List[Input], Input]] = None,
7575
manager: Optional[BaseBackgroundCallbackManager] = None,
7676
cache_args_to_ignore: Optional[list] = None,
7777
on_error: Optional[Callable[[Exception], Any]] = None,

0 commit comments

Comments
 (0)