feat: adding more type annotations to satisfy pyright

Author: gvwilson

components/dash-core-components/dash_core_components_base/__init__.py

@@ -13,7 +13,7 @@
     send_string,
 )
 
-__all__ = _components + [
+__all__ = _components + [  # type: ignore[reportUnsupportedDunderAll]
     "send_bytes",
     "send_data_frame",
     "send_file",

components/dash-table/dash_table_base/__init__.py

@@ -1,3 +1,5 @@
+# type: ignore
+
 import os as _os
 import sys as _sys
 import json

components/dash-table/src/dash-table/dash/DataTable.js

@@ -472,25 +472,14 @@ export const propTypes = {
      * View the documentation examples to learn more.
      *
      */
-    fixed_columns: PropTypes.oneOfType([
-        PropTypes.exact({
-            /**
-             * Example `{'headers':False, 'data':0}` No columns are fixed (the default)
-             */
-
-            data: PropTypes.oneOf([0]),
-            headers: PropTypes.oneOf([false])
-        }),
-
-        PropTypes.exact({
-            /**
-             * Example `{'headers':True, 'data':1}` one column is fixed.
-             */
+    fixed_columns: PropTypes.exact({
+        /**
+         * Example `{'headers':False, 'data':0}` No columns are fixed (the default)
+         */
 
-            data: PropTypes.number,
-            headers: PropTypes.oneOf([true]).isRequired
-        })
-    ]),
+        data: PropTypes.number,
+        headers: PropTypes.bool
+    }),
 
     /**
      * `fixed_rows` will "fix" the set of rows so that
@@ -505,24 +494,14 @@ export const propTypes = {
      * way that your columns are rendered or sized.
      * View the documentation examples to learn more.
      */
-    fixed_rows: PropTypes.oneOfType([
-        PropTypes.exact({
-            /**
-             * Example `{'headers':False, 'data':0}` No rows are fixed (the default)
-             */
-
-            data: PropTypes.oneOf([0]),
-            headers: PropTypes.oneOf([false])
-        }),
-        PropTypes.exact({
-            /**
-             * Example `{'headers':True, 'data':1}` one row is fixed.
-             */
+    fixed_rows: PropTypes.exact({
+        /**
+         * Example `{'headers':False, 'data':0}` No rows are fixed (the default)
+         */
 
-            data: PropTypes.number,
-            headers: PropTypes.oneOf([true]).isRequired
-        })
-    ]),
+        data: PropTypes.number,
+        headers: PropTypes.bool
+    }),
 
     /**
      * If `single`, then the user can select a single column or group

dash/_callback.py

@@ -360,7 +360,9 @@ def register_callback(
     # pylint: disable=too-many-locals
     def wrap_func(func):
 
-        if background is not None:
+        if background is None:
+            background_key = None
+        else:
             background_key = BaseBackgroundCallbackManager.register_func(
                 func,
                 background.get("progress") is not None,
@@ -515,7 +517,7 @@ def add_context(*args, **kwargs):
                     return to_json(response)
             else:
                 try:
-                    output_value = _invoke_callback(func, *func_args, **func_kwargs)
+                    output_value = _invoke_callback(func, *func_args, **func_kwargs)  # type: ignore[reportArgumentType]
                 except PreventUpdate as err:
                     raise err
                 except Exception as err:  # pylint: disable=broad-exception-caught
@@ -555,7 +557,7 @@ def add_context(*args, **kwargs):
                     if NoUpdate.is_no_update(val):
                         continue
                     for vali, speci in (
-                        zip(val, spec) if isinstance(spec, list) else [[val, spec]]
+                        zip(val, spec) if isinstance(spec, list) else [[val, spec]]  # type: ignore[reportArgumentType]]
                     ):
                         if not NoUpdate.is_no_update(vali):
                             has_update = True
@@ -590,6 +592,7 @@ def add_context(*args, **kwargs):
                 dist = app.get_dist(diff_packages)
                 response["dist"] = dist
 
+            jsonResponse = None
             try:
                 jsonResponse = to_json(response)
             except TypeError:

dash/_callback_context.py

@@ -207,15 +207,15 @@ def response(self):
 
     @staticmethod
     @has_context
-    def record_timing(name, duration=None, description=None):
+    def record_timing(name, duration, description=None):
         """Records timing information for a server resource.
 
         :param name: The name of the resource.
         :type name: string
 
         :param duration: The time in seconds to report. Internally, this
             is rounded to the nearest millisecond.
-        :type duration: float or None
+        :type duration: float
 
         :param description: A description of the resource.
         :type description: string or None

dash/_grouping.py

@@ -13,7 +13,7 @@
 structure
 
 """
-from dash.exceptions import InvalidCallbackReturnValue
+from .exceptions import InvalidCallbackReturnValue
 from ._utils import AttributeDict, stringify_id
 
 

dash/_jupyter.py

@@ -1,3 +1,4 @@
+# type: ignore
 import asyncio
 import io
 import inspect

dash/_pages.py

@@ -1,5 +1,6 @@
 import collections
 import importlib
+import importlib.util  # to make the type checker happy
 import os
 import re
 import sys
@@ -85,10 +86,9 @@ def _infer_path(module_name, template):
 
 
 def _module_name_is_package(module_name):
-    return (
-        module_name in sys.modules
-        and Path(sys.modules[module_name].__file__).name == "__init__.py"
-    )
+    file_path = sys.modules[module_name].__file__
+    assert file_path is not None  # to make type checker happy
+    return module_name in sys.modules and Path(file_path).name == "__init__.py"
 
 
 def _path_to_module_name(path):
@@ -441,6 +441,9 @@ def _import_layouts_from_pages(pages_folder):
 
             module_name = _infer_module_name(page_path)
             spec = importlib.util.spec_from_file_location(module_name, page_path)
+            assert (
+                spec is not None and spec.loader is not None
+            )  # to satisfy type checking
             page_module = importlib.util.module_from_spec(spec)
             spec.loader.exec_module(page_module)
             sys.modules[module_name] = page_module

dash/_utils.py

@@ -3,7 +3,7 @@
 import sys
 import uuid
 import hashlib
-import collections
+from collections import abc
 import subprocess
 import logging
 import io
@@ -15,8 +15,8 @@
 
 from html import escape
 from functools import wraps
-from typing import Union
-from dash.types import RendererHooks
+from typing import Union, cast
+from .types import RendererHooks
 
 logger = logging.getLogger()
 
@@ -58,7 +58,7 @@ def generate_hash():
 
 # pylint: disable=no-member
 def patch_collections_abc(member):
-    return getattr(collections.abc, member)
+    return getattr(abc, member)
 
 
 class AttributeDict(dict):
@@ -118,9 +118,11 @@ def __setitem__(self, key, val):
 
         return super().__setitem__(key, val)
 
-    def update(self, other):
+    def update(self, other=None, **kwargs):
         # Overrides dict.update() to use __setitem__ above
-        for k, v in other.items():
+        # Needs default `None` and `kwargs` to satisfy type checking
+        source = cast(dict, other) if other is not None else kwargs
+        for k, v in source.items():
             self[k] = v
 
     # pylint: disable=inconsistent-return-statements
@@ -251,7 +253,7 @@ def gen_salt(chars):
     )
 
 
-class OrderedSet(collections.abc.MutableSet):
+class OrderedSet(abc.MutableSet):
     def __init__(self, *args):
         self._data = []
         for i in args:

dash/_watch.py

@@ -6,7 +6,7 @@
 
 def watch(folders, on_change, pattern=None, sleep_time=0.1):
     pattern = re.compile(pattern) if pattern else None
-    watched = collections.defaultdict(lambda: -1)
+    watched = collections.defaultdict(lambda: -1.0)
 
     def walk():
         walked = []