Skip to content

Commit dd74965

Browse files
authored
Merge pull request #3334 from plotly/fix-close-on-select
fix closeOnSelect
2 parents 75a3752 + 6f6e16e commit dd74965

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
1717
## Added
1818
- [#3294](https://github.com/plotly/dash/pull/3294) Added the ability to pass `allow_optional` to Input and State to allow callbacks to work even if these components are not in the dash layout.
1919
- [#3077](https://github.com/plotly/dash/pull/3077) Add new parameter `assets_path_ignore` to `dash.Dash()`. Closes [#3076](https://github.com/plotly/dash/issues/3076)
20-
- [#3202](https://github.com/plotly/dash/pull/3202) expose the closeMenuOnSelect option in dropdown component
20+
- [#3202](https://github.com/plotly/dash/pull/3202) expose the closeOnSelect option in dropdown component
2121

2222
## Changed
2323

components/dash-core-components/src/components/Dropdown.react.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ Dropdown.propTypes = {
148148
/**
149149
* If false, the menu of the dropdown will not close once a value is selected.
150150
*/
151-
closeMenuOnSelect: PropTypes.bool,
151+
closeOnSelect: PropTypes.bool,
152152

153153
/**
154154
* height of each option. Can be increased when label lengths would wrap around
@@ -219,7 +219,7 @@ Dropdown.defaultProps = {
219219
searchable: true,
220220
optionHeight: 35,
221221
maxHeight: 200,
222-
closeMenuOnSelect: true,
222+
closeOnSelect: true,
223223
persisted_props: ['value'],
224224
persistence_type: 'local',
225225
};

components/dash-core-components/src/fragments/Dropdown.react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const RDProps = [
3333
'maxHeight',
3434
'style',
3535
'className',
36-
'closeMenuOnSelect',
36+
'closeOnSelect',
3737
];
3838

3939
const Dropdown = props => {

0 commit comments

Comments
 (0)