Deprate components on init.

Author: T4rk1n

components/dash-core-components/tests/integration/location/test_location_logout.py

@@ -1,58 +1,30 @@
-from dash.exceptions import PreventUpdate
 from dash import Dash, Input, Output, dcc, html
-import flask
 import pytest
 import time
 
 
 @pytest.mark.parametrize("add_initial_logout_button", [False, True])
 def test_llgo001_location_logout(dash_dcc, add_initial_logout_button):
+    # FIXME: Logout button is deprecated, remove this test for dash 3.0
     app = Dash(__name__)
 
-    @app.server.route("/_logout", methods=["POST"])
-    def on_logout():
-        rep = flask.redirect("/logged-out")
-        rep.set_cookie("logout-cookie", "", 0)
-        return rep
-
-    layout_children = [
-        html.H2("Logout test"),
-        dcc.Location(id="location"),
-        html.Div(id="content"),
-    ]
-    if add_initial_logout_button:
-        layout_children.append(dcc.LogoutButton())
-    app.layout = html.Div(layout_children)
-
-    @app.callback(Output("content", "children"), [Input("location", "pathname")])
-    def on_location(location_path):
-        if location_path is None:
-            raise PreventUpdate
-
-        if "logged-out" in location_path:
-            return "Logged out"
-        else:
-
-            @flask.after_this_request
-            def _insert_cookie(rep):
-                rep.set_cookie("logout-cookie", "logged-in")
-                return rep
-
-            return dcc.LogoutButton(id="logout-btn", logout_url="/_logout")
-
     with pytest.warns(
         DeprecationWarning,
         match="The Logout Button is no longer used with Dash Enterprise and can be replaced with a html.Button or html.A.",
     ):
-        dash_dcc.start_server(app)
-        time.sleep(1)
-        dash_dcc.percy_snapshot("Core Logout button")
-
-        assert dash_dcc.driver.get_cookie("logout-cookie")["value"] == "logged-in"
+        app.layout = [
+            html.H2("Logout test"),
+            html.Div(id="content"),
+        ]
+        if add_initial_logout_button:
+            app.layout.append(dcc.LogoutButton())
+        else:
 
-        dash_dcc.wait_for_element("#logout-btn").click()
-        dash_dcc.wait_for_text_to_equal("#content", "Logged out")
+            @app.callback(Output("content", "children"), Input("content", "id"))
+            def on_location(location_path):
+                return dcc.LogoutButton(id="logout-btn", logout_url="/_logout")
 
-        assert not dash_dcc.driver.get_cookie("logout-cookie")
+            dash_dcc.start_server(app)
+            time.sleep(1)
 
-        assert dash_dcc.get_logs() == []
+            assert dash_dcc.get_logs() == []

dash/_validate.py

@@ -1,8 +1,6 @@
 import sys
-from collections import defaultdict
 from collections.abc import MutableSequence
 import re
-import warnings
 from textwrap import dedent
 from keyword import iskeyword
 import flask
@@ -424,21 +422,6 @@ def validate_layout(layout, layout_value):
     component_ids = set()
 
     def _validate(value):
-        def _validate_type(comp):
-            deprecated_components = defaultdict(lambda: defaultdict(dict))
-            deprecated_components["dash_core_components"][
-                "LogoutButton"
-            ] = """
-                The Logout Button is no longer used with Dash Enterprise and can be replaced with a html.Button or html.A.
-                eg: html.A(href=os.getenv('DASH_LOGOUT_URL'))
-            """
-
-            _type = getattr(comp, "_type", "")
-            _ns = getattr(comp, "_namespace", "")
-            deprecation_message = deprecated_components[_ns][_type]
-            if deprecation_message:
-                warnings.warn(dedent(deprecation_message), DeprecationWarning)
-
         def _validate_id(comp):
             component_id = stringify_id(getattr(comp, "id", None))
             if component_id and component_id in component_ids:
@@ -449,11 +432,9 @@ def _validate_id(comp):
                 )
             component_ids.add(component_id)
 
-        _validate_type(value)
         _validate_id(value)
 
         for component in value._traverse():  # pylint: disable=protected-access
-            _validate_type(component)
             _validate_id(component)
 
     if isinstance(layout_value, (list, tuple)):

dash/development/base_component.py

@@ -4,13 +4,26 @@
 import sys
 import uuid
 import random
+import warnings
+import textwrap
 
 from .._utils import patch_collections_abc, stringify_id, OrderedSet
 
 MutableSequence = patch_collections_abc("MutableSequence")
 
 rd = random.Random(0)
 
+_deprecated_components = {
+    "dash_core_components": {
+        "LogoutButton": textwrap.dedent(
+            """
+        The Logout Button is no longer used with Dash Enterprise and can be replaced with a html.Button or html.A.
+        eg: html.A(href=os.getenv('DASH_LOGOUT_URL'))
+    """
+        )
+    }
+}
+
 
 # pylint: disable=no-init,too-few-public-methods
 class ComponentRegistry:
@@ -95,6 +108,7 @@ def __str__(self):
     REQUIRED = _REQUIRED()
 
     def __init__(self, **kwargs):
+        self._validate_deprecation()
         import dash  # pylint: disable=import-outside-toplevel, cyclic-import
 
         # pylint: disable=super-init-not-called
@@ -405,6 +419,13 @@ def __repr__(self):
             props_string = repr(getattr(self, "children", None))
         return f"{self._type}({props_string})"
 
+    def _validate_deprecation(self):
+        _type = getattr(self, "_type", "")
+        _ns = getattr(self, "_namespace", "")
+        deprecation_message = _deprecated_components.get(_ns, {}).get(_type)
+        if deprecation_message:
+            warnings.warn(DeprecationWarning(textwrap.dedent(deprecation_message)))
+
 
 def _explicitize_args(func):
     # Python 2