Change name of flag for accuracy

Author: marthacryan

dash/_configs.py

@@ -29,7 +29,7 @@ def load_dash_env_vars():
                 "DASH_HOT_RELOAD_WATCH_INTERVAL",
                 "DASH_HOT_RELOAD_MAX_RETRY",
                 "DASH_SILENCE_ROUTES_LOGGING",
-                "DASH_SILENCE_UPGRADE_NOTIFICATION",
+                "DASH_DISABLE_VERSION_CHECK",
                 "DASH_PRUNE_ERRORS",
                 "DASH_COMPRESS",
                 "HOST",

dash/dash-renderer/src/components/error/menu/VersionInfo.react.js

@@ -32,9 +32,6 @@ async function requestDashVersionInfo(config) {
         ddk_version: ddkVersion,
         plotly_version: plotlyVersion
     } = config;
-    if (!shouldRequestDashVersion(config)) {
-        return {};
-    }
     const cachedVersionInfo = localStorage.getItem('cachedNewDashVersion');
     const cachedNewDashVersionLink = localStorage.getItem(
         'cachedNewDashVersionLink'
@@ -49,7 +46,7 @@ async function requestDashVersionInfo(config) {
             version: JSON.parse(cachedVersionInfo),
             link: cachedNewDashVersionLink
         };
-    } else {
+    } else if (shouldRequestDashVersion(config)) {
         const queryParams = new URLSearchParams({
             dash_version: currentDashVersion,
             python_version: pythonVersion,
@@ -80,7 +77,7 @@ async function requestDashVersionInfo(config) {
 function shouldRequestDashVersion(config) {
     const showNotificationsLocalStorage =
         localStorage.getItem('showNotifications');
-    const showNotifications = config.silence_upgrade_notification
+    const showNotifications = config.disable_version_check
         ? false
         : showNotificationsLocalStorage !== 'false';
     const lastFetched = localStorage.getItem('lastFetched');
@@ -97,7 +94,7 @@ function shouldShowUpgradeNotification(
 ) {
     const showNotificationsLocalStorage =
         localStorage.getItem('showNotifications');
-    const showNotifications = config.silence_upgrade_notification
+    const showNotifications = config.disable_version_check
         ? false
         : showNotificationsLocalStorage !== 'false';
     const lastDismissed = localStorage.getItem('lastDismissed');

dash/dash.py

@@ -802,7 +802,7 @@ def _config(self):
             "requests_pathname_prefix": self.config.requests_pathname_prefix,
             "ui": self._dev_tools.ui,
             "props_check": self._dev_tools.props_check,
-            "silence_upgrade_notification": self._dev_tools.silence_upgrade_notification,
+            "disable_version_check": self._dev_tools.disable_version_check,
             "show_undo_redo": self.config.show_undo_redo,
             "suppress_callback_exceptions": self.config.suppress_callback_exceptions,
             "update_title": self.config.update_title,
@@ -1755,9 +1755,9 @@ def _setup_dev_tools(self, **kwargs):
                 get_combined_config(attr, kwargs.get(attr, None), default=default)
             )
 
-        dev_tools["silence_upgrade_notification"] = get_combined_config(
-            "silence_upgrade_notification",
-            kwargs.get("silence_upgrade_notification", None),
+        dev_tools["disable_version_check"] = get_combined_config(
+            "disable_version_check",
+            kwargs.get("disable_version_check", None),
             default=False,
         )
 
@@ -1774,7 +1774,7 @@ def enable_dev_tools(
         dev_tools_hot_reload_watch_interval=None,
         dev_tools_hot_reload_max_retry=None,
         dev_tools_silence_routes_logging=None,
-        dev_tools_silence_upgrade_notification=None,
+        dev_tools_disable_version_check=None,
         dev_tools_prune_errors=None,
     ):
         """Activate the dev tools, called by `run`. If your application
@@ -1795,7 +1795,7 @@ def enable_dev_tools(
             - DASH_HOT_RELOAD_WATCH_INTERVAL
             - DASH_HOT_RELOAD_MAX_RETRY
             - DASH_SILENCE_ROUTES_LOGGING
-            - DASH_SILENCE_UPGRADE_NOTIFICATION
+            - DASH_DISABLE_VERSION_CHECK
             - DASH_PRUNE_ERRORS
 
         :param debug: Enable/disable all the dev tools unless overridden by the
@@ -1841,10 +1841,10 @@ def enable_dev_tools(
             env: ``DASH_SILENCE_ROUTES_LOGGING``
         :type dev_tools_silence_routes_logging: bool
 
-        :param dev_tools_silence_upgrade_notification: Silence the upgrade
+        :param dev_tools_disable_version_check: Silence the upgrade
             notification to prevent making requests to the Dash server.
-            env: ``DASH_SILENCE_UPGRADE_NOTIFICATION``
-        :type dev_tools_silence_upgrade_notification: bool
+            env: ``DASH_DISABLE_VERSION_CHECK``
+        :type dev_tools_disable_version_check: bool
 
         :param dev_tools_prune_errors: Reduce tracebacks to just user code,
             stripping out Flask and Dash pieces. Only available with debugging.
@@ -1867,7 +1867,7 @@ def enable_dev_tools(
             hot_reload_watch_interval=dev_tools_hot_reload_watch_interval,
             hot_reload_max_retry=dev_tools_hot_reload_max_retry,
             silence_routes_logging=dev_tools_silence_routes_logging,
-            silence_upgrade_notification=dev_tools_silence_upgrade_notification,
+            disable_version_check=dev_tools_disable_version_check,
             prune_errors=dev_tools_prune_errors,
         )
 
@@ -2067,7 +2067,7 @@ def run(
         dev_tools_hot_reload_watch_interval: Optional[int] = None,
         dev_tools_hot_reload_max_retry: Optional[int] = None,
         dev_tools_silence_routes_logging: Optional[bool] = None,
-        dev_tools_silence_upgrade_notification: Optional[bool] = None,
+        dev_tools_disable_version_check: Optional[bool] = None,
         dev_tools_prune_errors: Optional[bool] = None,
         **flask_run_options,
     ):
@@ -2140,10 +2140,10 @@ def run(
             env: ``DASH_SILENCE_ROUTES_LOGGING``
         :type dev_tools_silence_routes_logging: bool
 
-        :param dev_tools_silence_upgrade_notification: Silence the upgrade
+        :param dev_tools_disable_version_check: Silence the upgrade
             notification to prevent making requests to the Dash server.
-            env: ``DASH_SILENCE_UPGRADE_NOTIFICATION``
-        :type dev_tools_silence_upgrade_notification: bool
+            env: ``DASH_DISABLE_VERSION_CHECK``
+        :type dev_tools_disable_version_check: bool
 
         :param dev_tools_prune_errors: Reduce tracebacks to just user code,
             stripping out Flask and Dash pieces. Only available with debugging.
@@ -2182,7 +2182,7 @@ def run(
             dev_tools_hot_reload_watch_interval,
             dev_tools_hot_reload_max_retry,
             dev_tools_silence_routes_logging,
-            dev_tools_silence_upgrade_notification,
+            dev_tools_disable_version_check,
             dev_tools_prune_errors,
         )
 

dash/testing/application_runners.py

@@ -162,7 +162,7 @@ def run():
             app.css.config.serve_locally = True
 
             options = kwargs.copy()
-            options["silence_upgrade_notification"] = True
+            options["disable_version_check"] = True
 
             if "port" not in kwargs:
                 options["port"] = self.port = BaseDashRunner._next_port