Address code review feedback

Author: KoolADE85

CHANGELOG.md

@@ -2,6 +2,12 @@
 All notable changes to `dash` will be documented in this file.
 This project adheres to [Semantic Versioning](https://semver.org/).
 
+## UNRELEASED
+
+## Fixed
+
+- [#2593](https://github.com/plotly/dash/pull/2593) dcc.Input accepts a number for its debounce argument
+
 ## [2.11.1] - 2023-06-29
 
 ## Fixed

components/dash-core-components/.eslintrc

@@ -117,7 +117,7 @@
     }],
     "no-magic-numbers": ["error", {
       "ignoreArrayIndexes": true,
-      "ignore": [-1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 100, 10, 16, 0.5, 25]
+      "ignore": [-1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 100, 10, 16, 0.5, 25, 1000]
     }],
     "no-underscore-dangle": ["off"],
     "no-useless-escape": ["off"]

components/dash-core-components/src/components/Input.react.js

@@ -134,15 +134,13 @@ export default class Input extends PureComponent {
         this.setState({pendingEvent: undefined});
     }
 
-    debounceEvent(time = 0.5) {
+    debounceEvent(seconds = 0.5) {
         const {value} = this.input.current;
-        const MILLISECONDS = 1000;
-        time = time * MILLISECONDS;
 
         window.clearTimeout(this.state?.pendingEvent);
         const pendingEvent = window.setTimeout(() => {
             this.onEvent();
-        }, time);
+        }, seconds * 1000);
 
         this.setState({
             value,

components/dash-core-components/tests/integration/input/test_debounce.py

@@ -16,7 +16,7 @@ def test_debounce_text_by_time(dash_dcc, debounce_text_app):
         )
 
     # but do expect that it is eventually called
-    assert dash_dcc.wait_for_text_to_equal(
+    dash_dcc.wait_for_text_to_equal(
         "#div-slow", "unit test slow"
     ), "long debounce is eventually called back"
 
@@ -42,7 +42,7 @@ def test_debounce_number_by_time(dash_dcc, debounce_number_app):
         )
 
     # but do expect that it is eventually called
-    assert dash_dcc.wait_for_text_to_equal(
+    dash_dcc.wait_for_text_to_equal(
         "#div-slow", "12345"
     ), "long debounce is eventually called back"