Skip to content

Commit ecc9089

Browse files
Fixed dropdown menu max height styling such that it isn't overwritten by the DataTable styling when it is added to the layout. Added test for checking this as well
1 parent 71b1e6f commit ecc9089

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
.dash-dropdown .Select-menu-outer {
22
z-index: 1000;
3+
max-height: none;
34
}
45

5-
.dash-dropdown .Select-menu, .Select-menu-outer {
6+
.dash-dropdown .Select-menu {
67
max-height: none;
78
}

components/dash-core-components/tests/integration/dropdown/test_visibility.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,10 @@ def test_ddvi001_fixed_table(dash_duo):
5050
def test_ddvi002_maxHeight(dash_duo):
5151
app = Dash(__name__)
5252
app.layout = Div(
53-
[Dropdown([str(i) for i in range(100)], "1", id="dropdown", maxHeight=800)]
53+
[
54+
DataTable(), # ensure datatable css does not override maxHeight #2529
55+
Dropdown([str(i) for i in range(100)], "1", id="dropdown", maxHeight=800),
56+
]
5457
)
5558

5659
dash_duo.start_server(app)

0 commit comments

Comments
 (0)