Skip to content

Commit fc6c200

Browse files
committed
adjusting test for dash_renderer.min.js to be from script
1 parent 96c1115 commit fc6c200

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

.circleci/config.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ jobs:
5656
pip list | grep dash
5757
npm ci
5858
npm run build.sequential
59-
cd dash/dash-renderer/build && cd ../../../
6059
python setup.py sdist
6160
mkdir dash-package && cp dist/*.tar.gz dash-package/dash-package.tar.gz
6261
ls -la dash-package

dash/dash-renderer/renderer-test.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
#!/bin/bash
2+
file=./build/dash_renderer.min.js
3+
if [ ! -f "$file" ]; then
4+
echo "dash-renderer did not build correctly"
5+
exit 1
6+
fi

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
"private::initialize.renderer": "cd dash/dash-renderer && npm ci",
99
"private::cibuild.components": "python dash/development/update_components.py 'all' --ci True",
1010
"private::build.components": "python dash/development/update_components.py 'all'",
11-
"private::cibuild.renderer": "cd dash/dash-renderer && renderer build",
12-
"private::build.renderer": "cd dash/dash-renderer && renderer build",
11+
"private::cibuild.renderer": "cd dash/dash-renderer && renderer build && sh renderer-test.sh",
12+
"private::build.renderer": "cd dash/dash-renderer && renderer build && sh renderer-test.sh",
1313
"private::build.jupyterlab": "cd @plotly/dash-jupyterlab && jlpm install && jlpm build:pack",
1414
"private::lint.black": "node -e \"if ((process.env.PYVERSION || 'python312') !== 'python38'){process.exit(1)} \" || black dash tests --exclude metadata_test.py --check",
1515
"private::lint.flake8": "flake8 --exclude=metadata_test.py dash tests",

0 commit comments

Comments
 (0)