Linting and test fixes

Author: HammadTheOne

dash/dash.py

@@ -1155,7 +1155,7 @@ def add_context(*args, **kwargs):
 
         return wrap_func
 
-    def long_callback(self, *_args, **_kwargs):
+    def long_callback(self, *_args, **_kwargs):  # pylint: disable=too-many-statements
         """
         Normally used as a decorator, `@app.long_callback` is an alternative to
         `@app.callback` designed for callbacks that take a long time to run,
@@ -1349,7 +1349,7 @@ def callback(_triggers, user_store_data, user_callback_args):
                         progress=clear_progress,
                         user_store_data=user_store_data,
                     )
-                elif progress_value:
+                if progress_value:
                     return dict(
                         user_callback_output=map_grouping(lambda x: no_update, output),
                         interval_disabled=False,

dash/long_callback/managers/diskcache_manager.py

@@ -25,7 +25,7 @@ def __init__(self, cache, cache_by=None, expire=None):
             import diskcache  # pylint: disable=import-outside-toplevel
             import psutil  # noqa: F401,E402 pylint: disable=import-outside-toplevel,unused-import,unused-variable,import-error
             import multiprocess  # noqa: F401,E402 pylint: disable=import-outside-toplevel,unused-import,unused-variable
-        except ImportError:
+        except ImportError as missing_imports:
             raise ImportError(
                 """\
 DiskcacheLongCallbackManager requires the multiprocess, diskcache, and psutil packages
@@ -36,7 +36,7 @@ def __init__(self, cache, cache_by=None, expire=None):
 or conda.
 
     $ conda install -c conda-forge multiprocess diskcache psutil\n"""
-            )
+            ) from missing_imports
 
         if not isinstance(cache, (diskcache.Cache, diskcache.FanoutCache)):
             raise ValueError("First argument must be a diskcache.Cache object")

tests/integration/long_callback/app1.py

@@ -1,15 +1,12 @@
-import dash
-from dash.dependencies import Input, Output
-import dash_html_components as html
-import dash_core_components as dcc
+from dash import Dash, Input, Output, dcc, html
 import time
 
 from tests.integration.long_callback.utils import get_long_callback_manager
 
 long_callback_manager = get_long_callback_manager()
 handle = long_callback_manager.handle
 
-app = dash.Dash(__name__)
+app = Dash(__name__)
 app.layout = html.Div(
     [
         dcc.Input(id="input", value="initial value"),

tests/integration/long_callback/app2.py

@@ -1,14 +1,13 @@
-import dash
-from dash.dependencies import Input, Output
-import dash_html_components as html
+from dash import Dash, Input, Output, html
+
 import time
 
 from tests.integration.long_callback.utils import get_long_callback_manager
 
 long_callback_manager = get_long_callback_manager()
 handle = long_callback_manager.handle
 
-app = dash.Dash(__name__, long_callback_manager=long_callback_manager)
+app = Dash(__name__, long_callback_manager=long_callback_manager)
 app.layout = html.Div(
     [
         html.Button(id="button-1", children="Click Here", n_clicks=0),

tests/integration/long_callback/app3.py

@@ -1,15 +1,12 @@
-import dash
-from dash.dependencies import Input, State, Output
-import dash_html_components as html
-import dash_core_components as dcc
+from dash import Dash, Input, Output, State, dcc, html
 import time
 
 from tests.integration.long_callback.utils import get_long_callback_manager
 
 long_callback_manager = get_long_callback_manager()
 handle = long_callback_manager.handle
 
-app = dash.Dash(__name__)
+app = Dash(__name__)
 app.layout = html.Div(
     [
         dcc.Input(id="input", value="initial value"),

tests/integration/long_callback/app4.py

@@ -1,7 +1,4 @@
-import dash
-from dash.dependencies import Input, State, Output
-import dash_html_components as html
-import dash_core_components as dcc
+from dash import Dash, Input, Output, State, dcc, html
 import time
 
 from tests.integration.long_callback.utils import get_long_callback_manager
@@ -10,7 +7,7 @@
 handle = long_callback_manager.handle
 
 
-app = dash.Dash(__name__, long_callback_manager=long_callback_manager)
+app = Dash(__name__, long_callback_manager=long_callback_manager)
 app.layout = html.Div(
     [
         dcc.Input(id="input", value="hello, world"),

tests/integration/long_callback/app5.py

@@ -1,7 +1,4 @@
-import dash
-from dash.dependencies import Input, State, Output
-import dash_html_components as html
-import dash_core_components as dcc
+from dash import Dash, Input, State, Output, dcc, html
 import time
 from multiprocessing import Value
 
@@ -11,7 +8,7 @@
 handle = long_callback_manager.handle
 
 
-app = dash.Dash(__name__, long_callback_manager=long_callback_manager)
+app = Dash(__name__, long_callback_manager=long_callback_manager)
 app._cache_key = Value("i", 0)
 
 

tests/integration/long_callback/app6.py

@@ -1,7 +1,5 @@
-import dash
-from dash.dependencies import Input, State, Output
-import dash_html_components as html
-import dash_core_components as dcc
+from dash import Dash, Input, Output, State, dcc, html
+
 import time
 from multiprocessing import Value
 
@@ -10,7 +8,7 @@
 long_callback_manager = get_long_callback_manager()
 handle = long_callback_manager.handle
 
-app = dash.Dash(__name__, long_callback_manager=long_callback_manager)
+app = Dash(__name__, long_callback_manager=long_callback_manager)
 app._cache_key = Value("i", 0)
 
 

tests/integration/long_callback/app7.py

@@ -1,7 +1,5 @@
-import dash
-from dash.dependencies import Input, State, Output
-import dash_html_components as html
-import dash_core_components as dcc
+from dash import Dash, Input, Output, State, dcc, html
+
 import time
 
 from tests.integration.long_callback.utils import get_long_callback_manager
@@ -10,7 +8,7 @@
 handle = long_callback_manager.handle
 
 
-app = dash.Dash(__name__, long_callback_manager=long_callback_manager)
+app = Dash(__name__, long_callback_manager=long_callback_manager)
 app.layout = html.Div(
     [
         html.Button(id="show-layout-button", children="Show"),