Make sure to reset debounce state after timeout

KoolADE85 · KoolADE85 · commit fe7a8e601d81 · 2023-07-10T10:24:00.000-06:00
diff --git a/components/dash-core-components/src/components/Input.react.js b/components/dash-core-components/src/components/Input.react.js
@@ -33,7 +33,7 @@ export default class Input extends PureComponent {
 
     UNSAFE_componentWillReceiveProps(nextProps) {
         const {value} = this.input.current;
-        if (this.state?.pendingEvent && nextProps.value !== value) {
+        if (this.state?.pendingEvent) {
             // avoid updating the input while awaiting a debounced event
             return;
         }
@@ -126,6 +126,7 @@ export default class Input extends PureComponent {
         } else {
             this.props.setProps({value});
         }
+        this.setState({pendingEvent: undefined});
     }
 
     debounceEvent(time = 0.5) {

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ export default class Input extends PureComponent {`
`33`	`33`
`34`	`34`	`UNSAFE_componentWillReceiveProps(nextProps) {`
`35`	`35`	`const {value} = this.input.current;`
`36`		`- if (this.state?.pendingEvent && nextProps.value !== value) {`
	`36`	`+ if (this.state?.pendingEvent) {`
`37`	`37`	`// avoid updating the input while awaiting a debounced event`
`38`	`38`	`return;`
`39`	`39`	`}`
`@@ -126,6 +126,7 @@ export default class Input extends PureComponent {`
`126`	`126`	`} else {`
`127`	`127`	`this.props.setProps({value});`
`128`	`128`	`}`
	`129`	`+ this.setState({pendingEvent: undefined});`
`129`	`130`	`}`
`130`	`131`
`131`	`132`	`debounceEvent(time = 0.5) {`