Skip to content

Commit fc65a0a

Browse files
HammadTheOneHammadTheOne
authored
Removing source maps from dependencies (#283)
1 parent c4ab3dc commit fc65a0a

19 files changed

+4
-134
lines changed

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
1010

1111
### Changed
1212
- Unified the core Dash packages (dash, dashCoreComponents, dashHtmlComponents, dashTable) for streamlined maintenance and accessibility. The namespaces of these packages will be combined under the `dash` namespace, and all artifacts from the ancillary dash packages will be included with Dash for R. [#243](https://github.com/plotly/dashr/pull/243)
13+
- Removed source-mapping from the `master` branch on Github and CRAN release of Dash R. Source-mapping is still available in the `dev` branch for contributors. [#282](https://github.com/plotly/dashR/pull/282)
1314

1415
### Fixed
1516
- Minor fix for favicon issue continued from [#240](https://github.com/plotly/dashr/pull/240) (for more details, see [#243](https://github.com/plotly/dashR/pull/243#issuecomment-842813526)).

‎R/internal.R‎

Lines changed: 3 additions & 117 deletions
Original file line numberDiff line numberDiff line change
@@ -47,18 +47,6 @@
4747
package = "dash",
4848
all_files = FALSE),
4949
class = "html_dependency"),
50-
`dash-renderer-map-dev` = structure(list(name = "dash-renderer",
51-
version = "1.8.3",
52-
src = list(href = "https://unpkg.com/[email protected]",
53-
file = "lib/[email protected]"),
54-
meta = NULL,
55-
script = "dash-renderer/dash_renderer.dev.js.map",
56-
stylesheet = NULL,
57-
head = NULL,
58-
attachment = NULL,
59-
package = "dash",
60-
all_files = FALSE),
61-
class = "html_dependency"),
6250
`dash-renderer-prod` = structure(list(name = "dash-renderer",
6351
version = "1.8.3",
6452
src = list(href = "https://unpkg.com/[email protected]",
@@ -71,18 +59,6 @@
7159
package = "dash",
7260
all_files = FALSE),
7361
class = "html_dependency"),
74-
`dash-renderer-map-prod` = structure(list(name = "dash-renderer",
75-
version = "1.8.3",
76-
src = list(href = "https://unpkg.com/[email protected]",
77-
file = "lib/[email protected]"),
78-
meta = NULL,
79-
script = "dash-renderer/dash_renderer.min.js.map",
80-
stylesheet = NULL,
81-
head = NULL,
82-
attachment = NULL,
83-
package = "dash",
84-
all_files = FALSE),
85-
class = "html_dependency"),
8662
`prop-types-dev` = structure(list(name = "prop-types",
8763
version = "15.7.2",
8864
src = list(href = "https://unpkg.com/[email protected]",
@@ -157,72 +133,18 @@ all_files = FALSE, async = TRUE), class = "html_dependency"),
157133
`dash_core_components` = structure(list(name = "dash_core_components",
158134
version = "2.0.0", src = list(href = NULL,
159135
file = "deps"), meta = NULL,
160-
script = 'dcc/async-datepicker.js.map',
161-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
162-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
163-
`dash_core_components` = structure(list(name = "dash_core_components",
164-
version = "2.0.0", src = list(href = NULL,
165-
file = "deps"), meta = NULL,
166-
script = 'dcc/async-dropdown.js.map',
167-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
168-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
169-
`dash_core_components` = structure(list(name = "dash_core_components",
170-
version = "2.0.0", src = list(href = NULL,
171-
file = "deps"), meta = NULL,
172-
script = 'dcc/async-graph.js.map',
173-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
174-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
175-
`dash_core_components` = structure(list(name = "dash_core_components",
176-
version = "2.0.0", src = list(href = NULL,
177-
file = "deps"), meta = NULL,
178-
script = 'dcc/async-highlight.js.map',
179-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
180-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
181-
`dash_core_components` = structure(list(name = "dash_core_components",
182-
version = "2.0.0", src = list(href = NULL,
183-
file = "deps"), meta = NULL,
184-
script = 'dcc/async-markdown.js.map',
185-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
186-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
187-
`dash_core_components` = structure(list(name = "dash_core_components",
188-
version = "2.0.0", src = list(href = NULL,
189-
file = "deps"), meta = NULL,
190-
script = 'dcc/async-slider.js.map',
191-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
192-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
193-
`dash_core_components` = structure(list(name = "dash_core_components",
194-
version = "2.0.0", src = list(href = NULL,
195-
file = "deps"), meta = NULL,
196-
script = 'dcc/async-upload.js.map',
197-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
198-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
199-
`dash_core_components` = structure(list(name = "dash_core_components",
200-
version = "2.0.0", src = list(href = NULL,
201-
file = "deps"), meta = NULL,
202136
script = 'dcc/dash_core_components.js',
203137
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
204138
all_files = FALSE), class = "html_dependency"),
205139
`dash_core_components` = structure(list(name = "dash_core_components",
206140
version = "2.0.0", src = list(href = NULL,
207141
file = "deps"), meta = NULL,
208-
script = 'dcc/dash_core_components.js.map',
209-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
210-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
211-
`dash_core_components` = structure(list(name = "dash_core_components",
212-
version = "2.0.0", src = list(href = NULL,
213-
file = "deps"), meta = NULL,
214142
script = 'dcc/dash_core_components-shared.js',
215143
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
216144
all_files = FALSE), class = "html_dependency"),
217145
`dash_core_components` = structure(list(name = "dash_core_components",
218146
version = "2.0.0", src = list(href = NULL,
219147
file = "deps"), meta = NULL,
220-
script = 'dcc/dash_core_components-shared.js.map',
221-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
222-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
223-
`dash_core_components` = structure(list(name = "dash_core_components",
224-
version = "2.0.0", src = list(href = NULL,
225-
file = "deps"), meta = NULL,
226148
script = 'dcc/plotly.min.js',
227149
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
228150
all_files = FALSE, async = 'eager'), class = "html_dependency"),
@@ -231,13 +153,7 @@ version = "2.0.0", src = list(href = NULL,
231153
file = "deps"), meta = NULL,
232154
script = 'dcc/async-plotlyjs.js',
233155
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
234-
all_files = FALSE, async = 'lazy'), class = "html_dependency"),
235-
`dash_core_components` = structure(list(name = "dash_core_components",
236-
version = "2.0.0", src = list(href = NULL,
237-
file = "deps"), meta = NULL,
238-
script = 'dcc/async-plotlyjs.js.map',
239-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
240-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"))
156+
all_files = FALSE, async = 'lazy'), class = "html_dependency"))
241157
return(deps_metadata)
242158
}
243159

@@ -248,13 +164,7 @@ version = "2.0.0", src = list(href = NULL,
248164
file = "deps"), meta = NULL,
249165
script = 'html/dash_html_components.min.js',
250166
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
251-
all_files = FALSE), class = "html_dependency"),
252-
`dash_html_components` = structure(list(name = "dash_html_components",
253-
version = "2.0.0", src = list(href = NULL,
254-
file = "deps"), meta = NULL,
255-
script = 'html/dash_html_components.min.js.map',
256-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
257-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"))
167+
all_files = FALSE), class = "html_dependency"))
258168
return(deps_metadata)
259169
}
260170

@@ -298,33 +208,9 @@ all_files = FALSE, async = TRUE), class = "html_dependency"),
298208
`dash_table` = structure(list(name = "dash_table",
299209
version = "5.0.0", src = list(href = NULL,
300210
file = "deps"), meta = NULL,
301-
script = 'dash_table/async-export.js.map',
302-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
303-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
304-
`dash_table` = structure(list(name = "dash_table",
305-
version = "5.0.0", src = list(href = NULL,
306-
file = "deps"), meta = NULL,
307-
script = 'dash_table/async-table.js.map',
308-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
309-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
310-
`dash_table` = structure(list(name = "dash_table",
311-
version = "5.0.0", src = list(href = NULL,
312-
file = "deps"), meta = NULL,
313-
script = 'dash_table/async-highlight.js.map',
314-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
315-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
316-
`dash_table` = structure(list(name = "dash_table",
317-
version = "5.0.0", src = list(href = NULL,
318-
file = "deps"), meta = NULL,
319211
script = 'dash_table/bundle.js',
320212
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
321-
all_files = FALSE), class = "html_dependency"),
322-
`dash_table` = structure(list(name = "dash_table",
323-
version = "5.0.0", src = list(href = NULL,
324-
file = "deps"), meta = NULL,
325-
script = 'dash_table/bundle.js.map',
326-
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
327-
all_files = FALSE, dynamic = TRUE), class = "html_dependency"))
213+
all_files = FALSE), class = "html_dependency"))
328214
return(deps_metadata)
329215
}
330216

‎inst/deps/dash_table/async-export.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎inst/deps/dash_table/async-highlight.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎inst/deps/dash_table/async-table.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎inst/deps/dash_table/bundle.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎inst/deps/dash_table/demo.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎inst/deps/dcc/async-datepicker.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎inst/deps/dcc/async-dropdown.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎inst/deps/dcc/async-graph.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)