always reduce an array of strings to a string when hoveron fills, addresses #1233

cpsievert · cpsievert · commit 124bce86ead9 · 2018-04-12T09:32:18.000-05:00
diff --git a/R/utils.R b/R/utils.R
@@ -480,8 +480,8 @@ verify_attr <- function(proposed, schema) {
     }
     
     # plotly.js should really handle this logic
-    if (identical(proposed[["hoveron"]], "fill")) {
-      proposed[["text"]] <- retain(proposed[["text"]], uniq)
+    if (isTRUE(grepl("fill", proposed[["hoveron"]]))) {
+      proposed[["text"]] <- paste(proposed[["text"]], collapse = "\n")
     }
     
     # ensure data_arrays of length 1 are boxed up by to_JSON()

Original file line number	Diff line number	Diff line change
`@@ -480,8 +480,8 @@ verify_attr <- function(proposed, schema) {`
`480`	`480`	`}`
`481`	`481`
`482`	`482`	`# plotly.js should really handle this logic`
`483`		`- if (identical(proposed[["hoveron"]], "fill")) {`
`484`		`- proposed[["text"]] <- retain(proposed[["text"]], uniq)`
	`483`	`+ if (isTRUE(grepl("fill", proposed[["hoveron"]]))) {`
	`484`	`+ proposed[["text"]] <- paste(proposed[["text"]], collapse = "\n")`
`485`	`485`	`}`
`486`	`486`
`487`	`487`	`# ensure data_arrays of length 1 are boxed up by to_JSON()`