Skip to content

Commit 25d721f

Browse files
committed
add waterfall to finance bundle and isosurface to gl3d
per discussion at plotly/plotly.js#3718
1 parent 9063b24 commit 25d721f

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

R/partial_bundles.R

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ verify_partial_bundle <- function(p) {
110110
# verify that this partial bundle actually supports this viz
111111
# (at this point, bundleType should never be 'auto' or 'main')
112112
missingTypes <- setdiff(types, bundleTraceMap[[bundleType]])
113+
113114
if (length(missingTypes)) {
114115
msg <- sprintf(
115116
"The '%s' bundle supports the following trace types: '%s'.\n\n This plotly visualization contains the following trace types: '%s'",
@@ -188,7 +189,8 @@ bundleTraceMap <- list(
188189
"scatter3d",
189190
"surface",
190191
"mesh3d",
191-
"cone"
192+
"cone",
193+
"isosurface"
192194
),
193195
gl2d = c(
194196
"scatter",
@@ -209,6 +211,7 @@ bundleTraceMap <- list(
209211
"pie",
210212
"histogram",
211213
"ohlc",
212-
"candlestick"
214+
"candlestick",
215+
"waterfall"
213216
)
214217
)

0 commit comments

Comments
 (0)