Merge pull request #1338 from ropensci/v1.41.0

plotly.js v1.41.3

Author: cpsievert

NEWS.md

@@ -7,7 +7,7 @@
 
 ## IMPROVEMENTS
 
-* Upgraded to plotly.js v1.40.1.
+* Upgraded to plotly.js v1.41.3.
 * The `orca()` function now supports conversion of much larger figures (#1322) and works without a mapbox api token (#1314).
 
 ## BUG FIXES

R/plotly.R

@@ -446,7 +446,7 @@ typedArrayPolyfill <- function() {
 plotlyMainBundle <- function() {
   htmltools::htmlDependency(
     "plotly-main", 
-    version = "1.40.1",
+    version = "1.41.3",
     src = depPath("plotlyjs"),
     script = "plotly-latest.min.js",
     all_files = FALSE

R/sysdata.rda

@@ -723,6 +723,13 @@ verify_key_type <- function(p) {
   for (i in seq_along(keys)) {
     k <- keys[[i]]
     if (is.null(k)) next
+    if ("select" %in% p$x$layout$clickmode && "plotly_click" %in% p$x$highlight$on) {
+      warning(
+        "`layout.clickmode` = 'select' is not designed to work well with ",
+        "the R package's linking framework (i.e. crosstalk support).",
+        call. = FALSE
+      )
+    }
     # does it *ever* make sense to have a missing key value?
     uk <- uniq(k)
     if (length(uk) == 1) {

R/utils.R

@@ -1,18 +1,23 @@
 context("highlighting and animation")
 
 m <- crosstalk::SharedData$new(mtcars, ~vs)
+p <- plot_ly(m, x = ~wt, y = ~mpg) %>% add_markers()
 
 test_that("SharedData produces key/set in plot_ly", {
-  m <- crosstalk::SharedData$new(mtcars, ~vs)
-  p <- plot_ly(m, x = ~wt, y = ~mpg) %>% add_markers()
   tr <- plotly_build(p)$x$data[[1]]
-  
   expect_true(all(tr$key == m$key()))
   expect_identical(tr$set, m$groupName())
   expect_false(tr$`_isNestedKey` %||% FALSE)
   expect_false(tr$`_isSimpleKey` %||% FALSE)
 })
 
+test_that("Warning is thrown when clickmode='select' is used with crosstalk", {
+  expect_warning(
+    plotly_build(layout(p, clickmode = "select")),
+    "not designed to work well"
+  )
+})
+
 test_that("SharedData produces key/set in ggplotly", {
   p <- ggplot(m, aes(x = wt, y = mpg)) + geom_point()
   tr <- plotly_build(p)$x$data[[1]]
@@ -24,6 +29,8 @@ test_that("SharedData produces key/set in ggplotly", {
   expect_false(tr$`_isSimpleKey` %||% FALSE)
 })
 
+
+
 test_that("crosstalk keys are inherited in a layer with inherit = FALSE", {
 
   p <- txhousing %>%